[GitHub] [qpid-proton] jiridanek edited a comment on pull request #254: PROTON-2125: suppress annoying deprecation warning from Minitest

[GitBox <gi...@apache.org>]

jiridanek edited a comment on pull request #254:
URL: https://github.com/apache/qpid-proton/pull/254#issuecomment-637568551


   > Ok, in that case do we want to actually split that change out from this one (as it definitely seems like it needs fixing) and create a separate matrix element for bionic then as I'm guessing the intent was to test on both bionic and xenial.
   
   I don't know what the intention was. I think I introduced that bionic line and it was by mistake ;( My deliberate suggestion now is to have xenial, bionic, but mostly focal in the matrix, as proposed in #246.
   
   > I think this fix (if we're going to use it at all) should be in the ruby CMakeLists.txt.
   
   That's what I wanted to specifically avoid touching. If I am setting options in CMake, I might just as well monkeypatch the warning out of minitest, or possibly even migrate the tests from the deprecated methods (and monkeypatch in the modern methods when using the rhel 7 version of minitest).
   
   Having quickly checked, it looks like `gem` is available as a package in rhel 7. That possibly means that using newer version of minitest from gem, instead of the packaged version, may be possible. Given that it is a test-only dependency.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org