You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/24 07:56:05 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25240: [SPARK-28496][INFRA] Use branch name instead of tag during dry-run

dongjoon-hyun commented on a change in pull request #25240: [SPARK-28496][INFRA] Use branch name instead of tag during dry-run
URL: https://github.com/apache/spark/pull/25240#discussion_r306673947
 
 

 ##########
 File path: dev/create-release/release-util.sh
 ##########
 @@ -150,6 +150,9 @@ function get_release_info {
   GIT_REF="$RELEASE_TAG"
   if is_dry_run; then
     echo "This is a dry run. Please confirm the ref that will be built for testing."
+    if [[ $SKIP_TAG = 0 ]]; then
+      GIT_REF="$GIT_BRANCH"
 
 Review comment:
   This changes only the default value in case of `DRY RUN`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org