You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Avery Ching (JIRA)" <ji...@apache.org> on 2012/08/07 20:06:10 UTC
[jira] [Created] (GIRAPH-288) Bandwidth tracking - subset of
GIRAPH-262
Avery Ching created GIRAPH-288:
----------------------------------
Summary: Bandwidth tracking - subset of GIRAPH-262
Key: GIRAPH-288
URL: https://issues.apache.org/jira/browse/GIRAPH-288
Project: Giraph
Issue Type: New Feature
Reporter: Avery Ching
Assignee: Avery Ching
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-288) Bandwidth tracking - subset of
GIRAPH-262
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-288:
-------------------------------
Attachment: GIRAPH-288.2.patch
Sorry, here's the correct rebase.
> Bandwidth tracking - subset of GIRAPH-262
> -----------------------------------------
>
> Key: GIRAPH-288
> URL: https://issues.apache.org/jira/browse/GIRAPH-288
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-288.2.patch, GIRAPH-288.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-288) Bandwidth tracking - subset of
GIRAPH-262
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-288:
-------------------------------
Attachment: (was: GIRAPH-288.patch)
> Bandwidth tracking - subset of GIRAPH-262
> -----------------------------------------
>
> Key: GIRAPH-288
> URL: https://issues.apache.org/jira/browse/GIRAPH-288
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-288.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-288) Bandwidth tracking - subset of
GIRAPH-262
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-288:
-------------------------------
Attachment: GIRAPH-288.patch
Rebased off of GIRAPH-289
> Bandwidth tracking - subset of GIRAPH-262
> -----------------------------------------
>
> Key: GIRAPH-288
> URL: https://issues.apache.org/jira/browse/GIRAPH-288
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-288.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-288) Bandwidth tracking - subset of
GIRAPH-262
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-288:
-------------------------------
Attachment: GIRAPH-288.patch
Split out the bandwidth tracking.
> Bandwidth tracking - subset of GIRAPH-262
> -----------------------------------------
>
> Key: GIRAPH-288
> URL: https://issues.apache.org/jira/browse/GIRAPH-288
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-288.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-288) Bandwidth tracking - subset of
GIRAPH-262
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430538#comment-13430538 ]
Eugene Koontz commented on GIRAPH-288:
--------------------------------------
+1
> Bandwidth tracking - subset of GIRAPH-262
> -----------------------------------------
>
> Key: GIRAPH-288
> URL: https://issues.apache.org/jira/browse/GIRAPH-288
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-288.2.patch, GIRAPH-288.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-288) Bandwidth tracking - subset of
GIRAPH-262
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430528#comment-13430528 ]
Eugene Koontz commented on GIRAPH-288:
--------------------------------------
Looks good except:
{code}
- Executors.newCachedThreadPool()));
+ Executors.newCachedThreadPool(),
+ conf.getInt(GiraphJob.MSG_NUM_FLUSH_THREADS,
+ NettyServer.DEFAULT_MAXIMUM_THREAD_POOL_SIZE)));
{code}
{code}
M extends Writable> {
/** Default maximum thread pool size */
- public static final int DEFAULT_MAXIMUM_THREAD_POOL_SIZE = 64;
+ public static final int DEFAULT_MAXIMUM_THREAD_POOL_SIZE = 32;
{code}
{code}
- try {
- workerThreadPool =
- (ThreadPoolExecutor) Executors.newCachedThreadPool(workerFactory);
- workerThreadPool.setMaximumPoolSize(maximumPoolSize);
- } catch (ClassCastException e) {
- LOG.warn("Netty worker thread pool is not of type ThreadPoolExecutor", e);
- }
+ Executors.newCachedThreadPool(workerFactory);
+
channelFactory = new NioServerSocketChannelFactory(
Executors.newCachedThreadPool(bossFactory),
- workerThreadPool);
+ Executors.newCachedThreadPool(workerFactory),
+ maximumPoolSize);
{code}
can be removed from this patch because they are part of GIRAPH-289.
> Bandwidth tracking - subset of GIRAPH-262
> -----------------------------------------
>
> Key: GIRAPH-288
> URL: https://issues.apache.org/jira/browse/GIRAPH-288
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-288.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-288) Bandwidth tracking - subset of
GIRAPH-262
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430572#comment-13430572 ]
Hudson commented on GIRAPH-288:
-------------------------------
Integrated in Giraph-trunk-Commit #161 (See [https://builds.apache.org/job/Giraph-trunk-Commit/161/])
GIRAPH-288: Bandwidth tracking - subset of GIRAPH-262. (aching) (Revision 1370438)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370438
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/src/main/java/org/apache/giraph/comm/ByteCounter.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/NettyClient.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/NettyServer.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/RequestDecoder.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/ResponseClientHandler.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/SendVertexRequest.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
* /giraph/trunk/src/main/java/org/apache/giraph/utils/TimedLogger.java
* /giraph/trunk/src/test/java/org/apache/giraph/comm/ConnectionTest.java
> Bandwidth tracking - subset of GIRAPH-262
> -----------------------------------------
>
> Key: GIRAPH-288
> URL: https://issues.apache.org/jira/browse/GIRAPH-288
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-288.2.patch, GIRAPH-288.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GIRAPH-288) Bandwidth tracking - subset of
GIRAPH-262
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching resolved GIRAPH-288.
--------------------------------
Resolution: Fixed
Thanks Eugene. Committed.
> Bandwidth tracking - subset of GIRAPH-262
> -----------------------------------------
>
> Key: GIRAPH-288
> URL: https://issues.apache.org/jira/browse/GIRAPH-288
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-288.2.patch, GIRAPH-288.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira