You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Gwen Shapira <gs...@cloudera.com> on 2015/02/17 21:17:40 UTC
Re: two very simple patch sets to be reviewed.
I've reviewed both (but can't commit obviously)
They are both safe (a rename and an addition to .gitignore).
The addition to .gitignore will be very useful for anyone who uses system
tests (which should be all of us).
The rename is useful only to those using IBM JDK (i.e. not all of us), but
since its just a rename, I figured there's no reason not to solve it.
Gwen
On Tue, Feb 17, 2015 at 10:05 AM, Tong Li <li...@us.ibm.com> wrote:
> Dear kafka developers,
> New to this community and put up two really small patch sets with open
> issues, can any one please review and comment and get them merged if all
> possible? Thanks
>
>
> https://reviews.apache.org/r/31088/
>
> https://reviews.apache.org/r/31097/
>
>
> Tong Li
> OpenStack Community Development
> Building 501/B205
> litong01@us.ibm.com
>
> [image: Inactive hide details for Tong Li---02/17/2015 01:03:36 PM---Dear
> kafka developers, New to this community and put up two real]Tong
> Li---02/17/2015 01:03:36 PM---Dear kafka developers, New to this
> community and put up two really small patch sets with open issu
>
> From: Tong Li/Raleigh/IBM
> To: kafka <de...@kafka.apache.org>
> Date: 02/17/2015 01:03 PM
> Subject: two very simple patch sets to be reviewed.
> ------------------------------
>
>
> Dear kafka developers,
> New to this community and put up two really small patch sets with open
> issues, can any one please review and comment and get them merged if all
> possible? Thanks
>
> https://reviews.apache.org/r/31097/
>
> https://reviews.apache.org/r/31097/
>
> Tong Li
> OpenStack & Kafka Community Development
> Building 501/B205
> litong01@us.ibm.com
>
>
Re: two very simple patch sets to be reviewed.
Posted by Tong Li <li...@us.ibm.com>.
Gwen,
Really appreciate it. Thanks so much. Anyone else please review them?
Here are the links again.
> https://reviews.apache.org/r/31088/
>
> https://reviews.apache.org/r/31097/
Tong Li
OpenStack Community Development
Building 501/B205
litong01@us.ibm.com
From: Gwen Shapira <gs...@cloudera.com>
To: "dev@kafka.apache.org" <de...@kafka.apache.org>
Date: 02/17/2015 03:29 PM
Subject: Re: two very simple patch sets to be reviewed.
I've reviewed both (but can't commit obviously)
They are both safe (a rename and an addition to .gitignore).
The addition to .gitignore will be very useful for anyone who uses system
tests (which should be all of us).
The rename is useful only to those using IBM JDK (i.e. not all of us), but
since its just a rename, I figured there's no reason not to solve it.
Gwen
On Tue, Feb 17, 2015 at 10:05 AM, Tong Li <li...@us.ibm.com> wrote:
> Dear kafka developers,
> New to this community and put up two really small patch sets with open
> issues, can any one please review and comment and get them merged if all
> possible? Thanks
>
>
> https://reviews.apache.org/r/31088/
>
> https://reviews.apache.org/r/31097/
>
>
> Tong Li
> OpenStack Community Development
> Building 501/B205
> litong01@us.ibm.com
>
> [image: Inactive hide details for Tong Li---02/17/2015 01:03:36 PM---Dear
> kafka developers, New to this community and put up two real]Tong
> Li---02/17/2015 01:03:36 PM---Dear kafka developers, New to this
> community and put up two really small patch sets with open issu
>
> From: Tong Li/Raleigh/IBM
> To: kafka <de...@kafka.apache.org>
> Date: 02/17/2015 01:03 PM
> Subject: two very simple patch sets to be reviewed.
> ------------------------------
>
>
> Dear kafka developers,
> New to this community and put up two really small patch sets with open
> issues, can any one please review and comment and get them merged if all
> possible? Thanks
>
> https://reviews.apache.org/r/31097/
>
> https://reviews.apache.org/r/31097/
>
> Tong Li
> OpenStack & Kafka Community Development
> Building 501/B205
> litong01@us.ibm.com
>
>