You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/04/02 09:24:47 UTC
[GitHub] [cassandra-dtest] Gerrrr opened a new pull request #61:
CASSANDRA-15679 Test COPY on collections with blobs
Gerrrr opened a new pull request #61: CASSANDRA-15679 Test COPY on collections with blobs
URL: https://github.com/apache/cassandra-dtest/pull/61
https://issues.apache.org/jira/browse/CASSANDRA-15679
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] stef1927 commented on issue #61: CASSANDRA-15679
Test COPY on collections with blobs
Posted by GitBox <gi...@apache.org>.
stef1927 commented on issue #61: CASSANDRA-15679 Test COPY on collections with blobs
URL: https://github.com/apache/cassandra-dtest/pull/61#issuecomment-611524093
Committed manually as 88cc70b4d6b598c60d4b567cdceff49a76140312.
@Gerrrr would you mind double checking and closing the PR if you can (I can't)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] stef1927 commented on a change in pull request
#61: CASSANDRA-15679 Test COPY on collections with blobs
Posted by GitBox <gi...@apache.org>.
stef1927 commented on a change in pull request #61: CASSANDRA-15679 Test COPY on collections with blobs
URL: https://github.com/apache/cassandra-dtest/pull/61#discussion_r402445998
##########
File path: cqlsh_tests/test_cqlsh_copy.py
##########
@@ -1788,9 +1794,15 @@ def test_all_datatypes_read(self):
writer = csv.writer(csvfile)
# serializing blob bytearray in friendly format
data_set = list(self.data)
- data_set[2] = '0x{}'.format(''.join('%02x' % c for c in self.data[2]))
+ data_set[2] = _format_blob(self.data[2])
+ data_set[25][3] = _format_blob(self.data[25][3])
+ data_set[26] = [_format_blob(el) for el in self.data[26]]
+ data_set[27] = {_format_blob(el) for el in self.data[27]}
writer.writerow(data_set)
+ def _format_blob(blob):
+ return '0x{}'.format(''.join('%02x' % c for c in self.data[2]))
+
Review comment:
I'm getting an error at line 1797 unless I move `format_blob` before it gets used. Also, `self.data[2]` should be `blob`? Once I fixed this, there was a problem with the indexes for `data_set`. Is this what you meant: https://github.com/stef1927/cassandra-dtest-1/commit/966e6db437cd0a6ecd731ffe9a6279a275065341?
If that commit is correct, I still see problems in copyutil unfortunately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] stef1927 commented on issue #61: CASSANDRA-15679
Test COPY on collections with blobs
Posted by GitBox <gi...@apache.org>.
stef1927 commented on issue #61: CASSANDRA-15679 Test COPY on collections with blobs
URL: https://github.com/apache/cassandra-dtest/pull/61#issuecomment-608084370
Final fixes for python 3 here: [efc29d3](https://github.com/stef1927/cassandra-dtest-1/commit/efc29d31fc71a1586e6d00ec0a671a732cd9f519). The branch is [here](https://github.com/stef1927/cassandra-dtest-1/commits/CASSANDRA-15679).
The 3 tests now pass locally for me, but I haven't been able to test with python 2 yet.
If you can do better that what I did [here](https://github.com/stef1927/cassandra-dtest-1/commit/efc29d31fc71a1586e6d00ec0a671a732cd9f519#diff-d9d0a60f4ae32bbc50dd7f4e74d407ceR1802), feel free to change the code. The problem is that the csv writer adds extra quotes around the blobs in the container structures but it does now when writing it at top level...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] Gerrrr closed pull request #61: CASSANDRA-15679
Test COPY on collections with blobs
Posted by GitBox <gi...@apache.org>.
Gerrrr closed pull request #61: CASSANDRA-15679 Test COPY on collections with blobs
URL: https://github.com/apache/cassandra-dtest/pull/61
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] stef1927 commented on a change in pull request
#61: CASSANDRA-15679 Test COPY on collections with blobs
Posted by GitBox <gi...@apache.org>.
stef1927 commented on a change in pull request #61: CASSANDRA-15679 Test COPY on collections with blobs
URL: https://github.com/apache/cassandra-dtest/pull/61#discussion_r402463867
##########
File path: cqlsh_tests/test_cqlsh_copy.py
##########
@@ -237,7 +237,10 @@ def all_datatypes_prepare(self):
u frozen<list<list<address_type>>>,
v frozen<map<map<int,int>,set<text>>>,
w frozen<set<set<inet>>>,
- x map<text, frozen<list<text>>>
+ x map<text, frozen<list<text>>>,
+ y map<int, blob>,
+ z list<blob>,
+ aa set<blob>
Review comment:
The columns need to be in alphabetical order, see 449e96b2a7aa8cc6dbbcf189e75b6f547e8e314f
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] Gerrrr commented on issue #61: CASSANDRA-15679
Test COPY on collections with blobs
Posted by GitBox <gi...@apache.org>.
Gerrrr commented on issue #61: CASSANDRA-15679 Test COPY on collections with blobs
URL: https://github.com/apache/cassandra-dtest/pull/61#issuecomment-611527001
Thank you, @stef1927!
I double checked https://github.com/apache/cassandra-dtest/commit/88cc70b4d6b598c60d4b567cdceff49a76140312 and it looks correct; closing this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org