You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/08/05 07:24:34 UTC
[GitHub] [pulsar] codelipenghui commented on a change in pull request #4888:
[pulsar-sql] Make partition as internal column
codelipenghui commented on a change in pull request #4888: [pulsar-sql] Make partition as internal column
URL: https://github.com/apache/pulsar/pull/4888#discussion_r310467396
##########
File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarInternalColumn.java
##########
@@ -39,6 +40,18 @@
public abstract class PulsarInternalColumn {
+ public static class PartitionColumn extends PulsarInternalColumn {
+
+ PartitionColumn(String name, Type type, String comment) {
+ super(name, type, comment);
+ }
+
+ @Override
+ public Object getData(RawMessage message) {
Review comment:
RawMessage does not contains partition now and get partition by split will reduce memory usage more than storing a partition per RawMessage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services