You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Gordon Smith <go...@adobe.com> on 2013/03/29 04:50:34 UTC
Falcon functional test failure
The frameworkSWC() test in SDKSWCTests is failing for me due to two compilation warnings warnings:
[junit] Expected: is <0>
[junit] got: <2>
[junit] Warning: variable definition duplicates function parameter: item.
[junit] )
[junit] var item:Object = removeItemAt(getItemIndex(item));
[junit] ^
[junit]
[junit] D:\asf\flex-sdk\frameworks\projects\framework\src\mx\collections\XMLListAdapter.as:419
[junit] Warning: variable definition duplicates function parameter: item.
[junit] var item:Object = removeItemAt[getItemIndex(item)];
I get the same thing in Eclipse. Does anybody else get this failure?
- Gordon
Re: Falcon functional test failure
Posted by Carlos Rovira <ca...@codeoscopic.com>.
commited. Sorry for the inconvenience.
Carlos
2013/3/29 Carlos Rovira <ca...@codeoscopic.com>
> Hi,
>
> this my fault. I'll commit the fix ASAP.
>
> thanks for seeing this.
>
> Best,
>
> Carlos
>
>
>
> 2013/3/29 Cyrill Zadra <cy...@gmail.com>
>
>> Same here.. It's a new warning which is introduced through this
>> commit.
>> https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commitdiff;h=461281f5818f25319391c6188805512cebc4d977
>> .
>> I guess we should rename it to _item?
>>
>>
>> On Fri, Mar 29, 2013 at 2:20 PM, Gordon Smith <go...@adobe.com> wrote:
>> > The frameworkSWC() test in SDKSWCTests is failing for me due to two
>> compilation warnings warnings:
>> >
>> > [junit] Expected: is <0>
>> > [junit] got: <2>
>> > [junit] Warning: variable definition duplicates function parameter:
>> item.
>> > [junit] )
>> > [junit] var item:Object =
>> removeItemAt(getItemIndex(item));
>> > [junit] ^
>> > [junit]
>> > [junit]
>> D:\asf\flex-sdk\frameworks\projects\framework\src\mx\collections\XMLListAdapter.as:419
>> > [junit] Warning: variable definition duplicates function parameter:
>> item.
>> > [junit] var item:Object =
>> removeItemAt[getItemIndex(item)];
>> >
>> > I get the same thing in Eclipse. Does anybody else get this failure?
>> >
>> > - Gordon
>> >
>>
>
>
>
> --
> Carlos Rovira
> Director de Tecnología
> M: +34 607 22 60 05
> F: +34 912 94 80 80
> http://www.codeoscopic.com
> http://www.directwriter.es
> http://www.avant2.es
>
--
Carlos Rovira
Director de Tecnología
M: +34 607 22 60 05
F: +34 912 94 80 80
http://www.codeoscopic.com
http://www.directwriter.es
http://www.avant2.es
Re: Falcon functional test failure
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Hi,
this my fault. I'll commit the fix ASAP.
thanks for seeing this.
Best,
Carlos
2013/3/29 Cyrill Zadra <cy...@gmail.com>
> Same here.. It's a new warning which is introduced through this
> commit.
> https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commitdiff;h=461281f5818f25319391c6188805512cebc4d977
> .
> I guess we should rename it to _item?
>
>
> On Fri, Mar 29, 2013 at 2:20 PM, Gordon Smith <go...@adobe.com> wrote:
> > The frameworkSWC() test in SDKSWCTests is failing for me due to two
> compilation warnings warnings:
> >
> > [junit] Expected: is <0>
> > [junit] got: <2>
> > [junit] Warning: variable definition duplicates function parameter:
> item.
> > [junit] )
> > [junit] var item:Object =
> removeItemAt(getItemIndex(item));
> > [junit] ^
> > [junit]
> > [junit]
> D:\asf\flex-sdk\frameworks\projects\framework\src\mx\collections\XMLListAdapter.as:419
> > [junit] Warning: variable definition duplicates function parameter:
> item.
> > [junit] var item:Object =
> removeItemAt[getItemIndex(item)];
> >
> > I get the same thing in Eclipse. Does anybody else get this failure?
> >
> > - Gordon
> >
>
--
Carlos Rovira
Director de Tecnología
M: +34 607 22 60 05
F: +34 912 94 80 80
http://www.codeoscopic.com
http://www.directwriter.es
http://www.avant2.es
Re: Falcon functional test failure
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Thanks to you for bring it out Gordon
:)
2013/3/29 Gordon Smith <go...@adobe.com>
> Ah, I see Carlos took care of it. Thanks, Carlos!
>
> - Gordon
>
> -----Original Message-----
> From: Gordon Smith [mailto:gosmith@adobe.com]
> Sent: Friday, March 29, 2013 10:12 AM
> To: dev@flex.apache.org
> Subject: RE: Falcon functional test failure
>
> Aha, I should have realized that it was likely a recent change to the
> framework.
>
> I recommend renaming it to removedItem. I try not to change the SDK
> because I'm not sure what tests I have to run. Are you willing to do it?
>
> - Gordon
>
> -----Original Message-----
> From: Cyrill Zadra [mailto:cyrill.zadra@gmail.com]
> Sent: Thursday, March 28, 2013 9:52 PM
> To: dev@flex.apache.org
> Subject: Re: Falcon functional test failure
>
> Same here.. It's a new warning which is introduced through this commit.
> https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commitdiff;h=461281f5818f25319391c6188805512cebc4d977
> .
> I guess we should rename it to _item?
>
>
> On Fri, Mar 29, 2013 at 2:20 PM, Gordon Smith <go...@adobe.com> wrote:
> > The frameworkSWC() test in SDKSWCTests is failing for me due to two
> compilation warnings warnings:
> >
> > [junit] Expected: is <0>
> > [junit] got: <2>
> > [junit] Warning: variable definition duplicates function parameter:
> item.
> > [junit] )
> > [junit] var item:Object =
> removeItemAt(getItemIndex(item));
> > [junit] ^
> > [junit]
> > [junit]
> D:\asf\flex-sdk\frameworks\projects\framework\src\mx\collections\XMLListAdapter.as:419
> > [junit] Warning: variable definition duplicates function parameter:
> item.
> > [junit] var item:Object =
> removeItemAt[getItemIndex(item)];
> >
> > I get the same thing in Eclipse. Does anybody else get this failure?
> >
> > - Gordon
> >
>
--
Carlos Rovira
Director de Tecnología
M: +34 607 22 60 05
F: +34 912 94 80 80
http://www.codeoscopic.com
http://www.directwriter.es
http://www.avant2.es
RE: Falcon functional test failure
Posted by Gordon Smith <go...@adobe.com>.
Ah, I see Carlos took care of it. Thanks, Carlos!
- Gordon
-----Original Message-----
From: Gordon Smith [mailto:gosmith@adobe.com]
Sent: Friday, March 29, 2013 10:12 AM
To: dev@flex.apache.org
Subject: RE: Falcon functional test failure
Aha, I should have realized that it was likely a recent change to the framework.
I recommend renaming it to removedItem. I try not to change the SDK because I'm not sure what tests I have to run. Are you willing to do it?
- Gordon
-----Original Message-----
From: Cyrill Zadra [mailto:cyrill.zadra@gmail.com]
Sent: Thursday, March 28, 2013 9:52 PM
To: dev@flex.apache.org
Subject: Re: Falcon functional test failure
Same here.. It's a new warning which is introduced through this commit. https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commitdiff;h=461281f5818f25319391c6188805512cebc4d977.
I guess we should rename it to _item?
On Fri, Mar 29, 2013 at 2:20 PM, Gordon Smith <go...@adobe.com> wrote:
> The frameworkSWC() test in SDKSWCTests is failing for me due to two compilation warnings warnings:
>
> [junit] Expected: is <0>
> [junit] got: <2>
> [junit] Warning: variable definition duplicates function parameter: item.
> [junit] )
> [junit] var item:Object = removeItemAt(getItemIndex(item));
> [junit] ^
> [junit]
> [junit] D:\asf\flex-sdk\frameworks\projects\framework\src\mx\collections\XMLListAdapter.as:419
> [junit] Warning: variable definition duplicates function parameter: item.
> [junit] var item:Object = removeItemAt[getItemIndex(item)];
>
> I get the same thing in Eclipse. Does anybody else get this failure?
>
> - Gordon
>
RE: Falcon functional test failure
Posted by Gordon Smith <go...@adobe.com>.
Aha, I should have realized that it was likely a recent change to the framework.
I recommend renaming it to removedItem. I try not to change the SDK because I'm not sure what tests I have to run. Are you willing to do it?
- Gordon
-----Original Message-----
From: Cyrill Zadra [mailto:cyrill.zadra@gmail.com]
Sent: Thursday, March 28, 2013 9:52 PM
To: dev@flex.apache.org
Subject: Re: Falcon functional test failure
Same here.. It's a new warning which is introduced through this commit. https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commitdiff;h=461281f5818f25319391c6188805512cebc4d977.
I guess we should rename it to _item?
On Fri, Mar 29, 2013 at 2:20 PM, Gordon Smith <go...@adobe.com> wrote:
> The frameworkSWC() test in SDKSWCTests is failing for me due to two compilation warnings warnings:
>
> [junit] Expected: is <0>
> [junit] got: <2>
> [junit] Warning: variable definition duplicates function parameter: item.
> [junit] )
> [junit] var item:Object = removeItemAt(getItemIndex(item));
> [junit] ^
> [junit]
> [junit] D:\asf\flex-sdk\frameworks\projects\framework\src\mx\collections\XMLListAdapter.as:419
> [junit] Warning: variable definition duplicates function parameter: item.
> [junit] var item:Object = removeItemAt[getItemIndex(item)];
>
> I get the same thing in Eclipse. Does anybody else get this failure?
>
> - Gordon
>
Re: Falcon functional test failure
Posted by Cyrill Zadra <cy...@gmail.com>.
Same here.. It's a new warning which is introduced through this
commit. https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commitdiff;h=461281f5818f25319391c6188805512cebc4d977.
I guess we should rename it to _item?
On Fri, Mar 29, 2013 at 2:20 PM, Gordon Smith <go...@adobe.com> wrote:
> The frameworkSWC() test in SDKSWCTests is failing for me due to two compilation warnings warnings:
>
> [junit] Expected: is <0>
> [junit] got: <2>
> [junit] Warning: variable definition duplicates function parameter: item.
> [junit] )
> [junit] var item:Object = removeItemAt(getItemIndex(item));
> [junit] ^
> [junit]
> [junit] D:\asf\flex-sdk\frameworks\projects\framework\src\mx\collections\XMLListAdapter.as:419
> [junit] Warning: variable definition duplicates function parameter: item.
> [junit] var item:Object = removeItemAt[getItemIndex(item)];
>
> I get the same thing in Eclipse. Does anybody else get this failure?
>
> - Gordon
>