[GitHub] [airflow] houqp commented on a change in pull request #6472: [AIRFLOW-6058] Running tests with pytest

[GitBox <gi...@apache.org>]

houqp commented on a change in pull request #6472: [AIRFLOW-6058] Running tests with pytest
URL: https://github.com/apache/airflow/pull/6472#discussion_r351466604
 
 

 ##########
 File path: tests/task/task_runner/test_standard_task_runner.py
 ##########
 @@ -121,11 +121,16 @@ def test_on_kill(self):
         runner = StandardTaskRunner(job1)
         runner.start()
 
-        # give the task some time to startup
-        time.sleep(3)
-
+        # Give the task some time to startup
+        time.sleep(10)
         runner.terminate()
 
+        # Wait some time for the result
+        for _ in range(5):
+            if os.path.exists(path):
+                break
+            time.sleep(8)
 
 Review comment:
   8 seconds seems like a lot, i would recommend increase the range count and decrease the sleep interval here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services