You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2024/04/24 08:30:18 UTC
[PR] fix(trait): harmonize service port name [camel-k]
squakez opened a new pull request, #5411:
URL: https://github.com/apache/camel-k/pull/5411
As Knative accepts a limited set of names, we can harmonize the default values to use the same accepted names.
Close #5409
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
fix(trait): harmonize service port name
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): controller strategy default service port name [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #5411:
URL: https://github.com/apache/camel-k/pull/5411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): controller strategy default service port name [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5411:
URL: https://github.com/apache/camel-k/pull/5411#issuecomment-2076831114
Should be good to go now. I've worked to define a more generic approach and let any trait requiring to know the port name to use a function that will return the default based on the controller strategy used. It should be compatible with the existing Deployment as will still return `http` conversely to the previous commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): harmonize service port name [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5411:
URL: https://github.com/apache/camel-k/pull/5411#issuecomment-2074390263
@lburgazzoli do you know if this change may create any problem for other deployment strategy or other clusters (ie, Openshift) by any chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): harmonize service port name [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5411:
URL: https://github.com/apache/camel-k/pull/5411#issuecomment-2074475299
> In general if you use a service, it should not be an issue, however it may break customer deployment if they were using such name in any external tool for any reason i.e. in prometheus' `PodMonitor`
Yes, if the monitoring is external, then, we cannot control that. I'll move this change to apply exclusively to Knative, however, there are several places where this is happening, so we need to make more verification about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): harmonize service port name [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #5411:
URL: https://github.com/apache/camel-k/pull/5411#issuecomment-2074451348
In general if you use a service, it should not be an issue, however it may break customer deployment if they were using such name in any external tool for any reason i.e. in prometheus' `PodMonitor`
```yaml
apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
name: example-app
labels:
team: frontend
spec:
selector:
matchLabels:
app: example-app
podMetricsEndpoints:
- port: http
```
I wonder if we should make this change knative only at least for now and eventually failing the `integration` if the use changes the port name for a `Knative` deployment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): harmonize service port name [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #5411:
URL: https://github.com/apache/camel-k/pull/5411#issuecomment-2074473603
As side note, this would probably cause all the integration Pods to be restarted when the operator gets upgraded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org