You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/14 03:59:36 UTC
[GitHub] [shardingsphere-elastic-job-lite] CYXK opened a new pull request #776: remove comment code
CYXK opened a new pull request #776:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/776
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
- git can help us manage code, so comment code should remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elastic-job-lite] Technoboy- commented on pull request #776: remove comment code
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #776:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/776#issuecomment-644004105
> Sorry, this plugin cannot be remove because I just comment it temporary and make the test pass, I will investigate why it cause test cases broken.
Hi, John. I try to run the command with 'mvn clean install' after un-comment the plugin 'maven-surefire-plugin', it shows BUILD SUCCESS . I think we don't need to comment it. Please try again. If test case can't pass, please let me know, I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elastic-job-lite] terrymanu commented on pull request #776: remove comment code
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #776:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/776#issuecomment-644093657
@Technoboy- Thank you for reminder, I just fix it at #779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elastic-job-lite] terrymanu closed pull request #776: remove comment code
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #776:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org