You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "ThrawnCA (via GitHub)" <gi...@apache.org> on 2026/01/29 01:42:51 UTC
[PR] Make TokenInterceptor use the struts package instead of xwork [struts]
ThrawnCA opened a new pull request, #1561:
URL: https://github.com/apache/struts/pull/1561
- Extend org.apache.struts2.interceptor.MethodFilterInterceptor instead of com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make TokenInterceptor use the struts package instead of xwork [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #1561:
URL: https://github.com/apache/struts/pull/1561#issuecomment-3831163330
What's the purpose of this change? We keep "xwork" packages to support older apps and to avoid migration burden. If you want to use the new "struts2" packages it's better to migrate to Struts 7.x as Struts 6.x is maintenance mode and only some of the fixes are going to be ported into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make TokenInterceptor use the struts package instead of xwork [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk commented on PR #1561:
URL: https://github.com/apache/struts/pull/1561#issuecomment-3833452013
> Moving to Struts 7 requires a full migration to EE9+, which means changing a whole lot of components at once. The aim here is to break it into smaller pieces.
It shouldn't come at the cost of breaking existing applications which consume Struts 6.x. Fortunately, in this case, we can make the dependency on the `xwork2` package optional whilst retaining backwards compatibility. See #1565 - feel free to test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make TokenInterceptor use the struts package instead of xwork [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk commented on PR #1561:
URL: https://github.com/apache/struts/pull/1561#issuecomment-3888277495
Going ahead and closing this PR in favour of #1565 then. We can't merge this breaking change into Struts 6.x regardless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make TokenInterceptor use the struts package instead of xwork [struts]
Posted by "ThrawnCA (via GitHub)" <gi...@apache.org>.
ThrawnCA commented on PR #1561:
URL: https://github.com/apache/struts/pull/1561#issuecomment-3888257080
> @ThrawnCA have you had a chance to test the linked alternative PR to see if it is suitable for your needs?
No, we have had other priorities. It does look like it should work, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make TokenInterceptor use the struts package instead of xwork [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk commented on PR #1561:
URL: https://github.com/apache/struts/pull/1561#issuecomment-3888219802
@ThrawnCA have you had a chance to test the linked alternative PR to see if it is suitable for your needs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make TokenInterceptor use the struts package instead of xwork [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk closed pull request #1561: Make TokenInterceptor use the struts package instead of xwork
URL: https://github.com/apache/struts/pull/1561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make TokenInterceptor use the struts package instead of xwork [struts]
Posted by "ThrawnCA (via GitHub)" <gi...@apache.org>.
ThrawnCA commented on PR #1561:
URL: https://github.com/apache/struts/pull/1561#issuecomment-3831905154
> What's the purpose of this change? We keep "xwork" packages to support older apps and to avoid migration burden.
Currently, if you extend TokenInterceptor, then you're still reliant on the xwork package and can't migrate.
Moving to Struts 7 requires a full migration to EE9+, which means changing a whole lot of components at once. The aim here is to break it into smaller pieces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org