You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Dennis-Mircea (via GitHub)" <gi...@apache.org> on 2026/04/20 16:06:43 UTC
[PR] [FLINK-39501] Logback Support in Flink Kubernetes Operator [flink-kubernetes-operator]
Dennis-Mircea opened a new pull request, #1096:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1096
<!--
*Thank you very much for contributing to the Apache Flink Kubernetes Operator - we are happy that you want to help us improve the project. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix][docs] Fix typo in event time introduction` or `[hotfix][javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can read more on how we use GitHub Actions for CI [here](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/development/guide/#cicd).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request introduces Logback as an alternative logging framework for the Flink Kubernetes Operator, selectable at install time via the `logging.framework` Helm value. Previously, only Log4j2 was supported.
> **Note:** This change covers the main operator module only. The `flink-autoscaler-standalone`, which runs as an independent process with its own logging stack, is not included in this scope.
## Brief change log
- Add default `logback-operator.xml` and `logback-console.xml` configuration files with log output format aligned to the existing Log4j2 defaults
- Add `logging.framework` Helm value to switch between `log4j2` (default) and `logback` at install time
- Update `docker-entrypoint.sh` to place the correct SLF4J binding JAR on the classpath based on the selected framework
- Update Helm deployment template to mount the appropriate logging config files and pass the correct JVM system property
- Fix ConfigMap template to use a replacement strategy for Logback XML overrides (XML cannot be concatenated like `.properties` files)
- Add E2E tests for both Log4j2 and Logback logging verification (`test_log4j2_logging.sh`, `test_logback_logging.sh`)
- Wire logging E2E tests into the CI pipeline (`e2e_logging` job in `ci.yml`)
- Update Metrics and Logging documentation (English and Chinese) with framework selection, configuration examples, XML override behavior, and SLF4J version constraints
## Verifying this change
<!--
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
-->
This change added tests and can be verified as follows:
- Added `test_log4j2_logging.sh` E2E test that deploys the operator with the default Log4j2 framework and verifies log format (timestamp with `,` millisecond separator, logger name, log level)
- Added `test_logback_logging.sh` E2E test that switches the framework to Logback via `values.yaml` and verifies log format (timestamp with `.` millisecond separator, logger name, log level)
- Both tests strip ANSI escape codes and validate format using POSIX-compatible regex patterns
- Helm unit tests pass: `helm unittest -f 'tests/**/*_test.yaml' helm/flink-kubernetes-operator` (14 suites, 60 tests)
- Manually verified by deploying the operator with both `--set logging.framework=log4j2` and `--set logging.framework=logback`, confirming correct log output format in `kubectl logs`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39501] Logback Support in Flink Kubernetes Operator [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora merged PR #1096:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39501] Logback Support in Flink Kubernetes Operator [flink-kubernetes-operator]
Posted by "Dennis-Mircea (via GitHub)" <gi...@apache.org>.
Dennis-Mircea commented on PR #1096:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1096#issuecomment-4327116036
> please rebase
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39501] Logback Support in Flink Kubernetes Operator [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #1096:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1096#issuecomment-4326587487
please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org