You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/17 18:04:28 UTC

[GitHub] [arrow] jorgecarleitao opened a new pull request #8695: ARROW-10631: [Rust] Fixed error in computing equality of fixed-sized binary.

jorgecarleitao opened a new pull request #8695:
URL: https://github.com/apache/arrow/pull/8695


   This fixes a bug on the equality for fixed-sized binary arrays. For these types, the number of bytes of a slot equals the specified size. However, we were not taking that into account when offsetting in number of slots in the comparison.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jhorstmann commented on pull request #8695: ARROW-10631: [Rust] Fixed error in computing equality of fixed-sized binary.

Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #8695:
URL: https://github.com/apache/arrow/pull/8695#issuecomment-729145014


   LGTM. Logic now matches `primitive_equal` which also has to depend on the size of the type.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me closed pull request #8695: ARROW-10631: [Rust] Fixed error in computing equality of fixed-sized binary.

Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #8695:
URL: https://github.com/apache/arrow/pull/8695


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #8695: ARROW-10631: [Rust] Fixed error in computing equality of fixed-sized binary.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8695:
URL: https://github.com/apache/arrow/pull/8695#issuecomment-729104750


   https://issues.apache.org/jira/browse/ARROW-10631


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org