[GitHub] [netbeans] jlahoda commented on a change in pull request #3321: Fixing handling of multi-source JavaSources on older JDKs.

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #3321:
URL: https://github.com/apache/netbeans/pull/3321#discussion_r751135563



##########
File path: java/java.source.base/src/org/netbeans/modules/java/source/parsing/JavacParser.java
##########
@@ -772,29 +772,25 @@ Phase moveToPhase (final Phase phase, final CompilationInfoImpl currentInfo, Lis
                         compiler.todo.offer(env);
                     }
                 }
-                currentPhase = Phase.RESOLVED;
+                if (!lowMemoryCancel.get()) {

Review comment:
       Yes, old(er) versions of javac will not propagate the exceptions from the parse and analyze methods. See:
   https://github.com/openjdk/jdk/commit/433394203dce55db95caefcb57bac9ec114ebc47




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists