You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/12 18:58:43 UTC
[GitHub] [incubator-tvm] zhiics opened a new pull request #4692:
[tvm][runtime] Add FFI for ADT
zhiics opened a new pull request #4692: [tvm][runtime] Add FFI for ADT
URL: https://github.com/apache/incubator-tvm/pull/4692
This PR adds ADT to FFI so that we can pass it during the runtime. After this PR, we should be able to replace the TupleValue objects directly with ADT.
cc @tqchen @wweic @icemelon9 @jroesch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #4692:
[tvm][runtime] Add FFI for ADT
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #4692: [tvm][runtime] Add FFI for ADT
URL: https://github.com/apache/incubator-tvm/pull/4692#issuecomment-573450404
I am not sure it is the right way. From the developer's perspective, ADT is simply a subclass of object, so the current FFI should already be able to handle it (as an Object).
NOTE: NDArray and Module are specially handled to deal with the C API backward compact and keep the C API simple. Module for example, could have been directly folded into Object
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #4692: [tvm][runtime] Add
FFI for ADT
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #4692: [tvm][runtime] Add FFI for ADT
URL: https://github.com/apache/incubator-tvm/pull/4692#issuecomment-573467040
yeah, I see your point. Let's close this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #4692: [tvm][runtime] Add
FFI for ADT
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #4692: [tvm][runtime] Add FFI for ADT
URL: https://github.com/apache/incubator-tvm/pull/4692#issuecomment-573463524
we could register with `TVM_REGISTER_NODE_TYPE` as well. It seems this is mainly used for objects that are not used by runtime. Am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics closed pull request #4692: [tvm][runtime]
Add FFI for ADT
Posted by GitBox <gi...@apache.org>.
zhiics closed pull request #4692: [tvm][runtime] Add FFI for ADT
URL: https://github.com/apache/incubator-tvm/pull/4692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #4692:
[tvm][runtime] Add FFI for ADT
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #4692: [tvm][runtime] Add FFI for ADT
URL: https://github.com/apache/incubator-tvm/pull/4692#issuecomment-573450404
I am not sure it is the right way. From the developer's perspective, ADT is simply a subclass of object, so the current FFI should already be able to handle it (as an Object), so these changes are not necessary
NOTE: NDArray and Module are specially handled to deal with the C API backward compact and keep the C API simple. Module for example, could have been directly folded into Object
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4692: [tvm][runtime] Add
FFI for ADT
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4692: [tvm][runtime] Add FFI for ADT
URL: https://github.com/apache/incubator-tvm/pull/4692#issuecomment-573450404
I am not sure it is the right way. From the developer's perspective, ADT is simply a subclass of object, so the current FFI should already be able to handle it (as an Object)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services