You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "mcc0nnell (via GitHub)" <gi...@apache.org> on 2026/10/02 17:26:56 UTC
[PR] Align legacy idempotency key storage width [fineract]
mcc0nnell opened a new pull request, #6566:
URL: https://github.com/apache/fineract/pull/6566
Core Fineract currently accepts the configured idempotency header without applying a length constraint before command processing. The legacy `m_portfolio_command_source.idempotency_key` column and its JPA mapping are limited to 50 characters, while the newer JDBC command store uses `VARCHAR(255)`.
This change keeps the two command-storage paths consistent by:
- widening `m_portfolio_command_source.idempotency_key` from 50 to 255 characters via a new Liquibase migration
- updating the `CommandSource` JPA mapping to match
- leaving existing idempotency behavior and keys unchanged
This is intentionally separate from apache/fineract#6231, which is hardening idempotency semantics for the newer command-processing path. This patch only removes a storage-width inconsistency in the legacy path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align legacy idempotency key storage width [fineract]
Posted by "mcc0nnell (via GitHub)" <gi...@apache.org>.
mcc0nnell commented on PR #6566:
URL: https://github.com/apache/fineract/pull/6566#issuecomment-5994682001
@IOhacker Conflict is resolved on the current signed head `df563d9cda1dd9774b6a4f1e5e95c6742b57d989`, and GitHub now reports the PR as mergeable. The resolution preserves upstream migrations `0254`/`0255` and renumbers this PR's idempotency-key migration to ; the JPA mapping remains . The new Fineract CI, PR Compliance, and Signed Commits Check runs are all blocked at GitHub's fork-workflow `action_required` approval gate with no jobs started. Could you please approve and run the workflows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2485: Align legacy idempotency key storage width [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #6566:
URL: https://github.com/apache/fineract/pull/6566#issuecomment-6238868059
@mcc0nnell Please rebase onto the latest `develop` and resolve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align legacy idempotency key storage width [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #6566:
URL: https://github.com/apache/fineract/pull/6566#issuecomment-5988041277
@mcc0nnell please resolve the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2485: Align legacy idempotency key storage width [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #6566:
URL: https://github.com/apache/fineract/pull/6566#issuecomment-5996452304
@mcc0nnell Please make sure your commits are GPG signed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org