You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "hosea (via GitHub)" <gi...@apache.org> on 2025/11/27 23:56:55 UTC
[PR] Feature/wicket 7170 followup improve tests [wicket]
hosea opened a new pull request, #1312:
URL: https://github.com/apache/wicket/pull/1312
This is a follow-up-PR addressing only the tests of AnnotProxyFieldValueFactory.
Tests were completly updated and rewritten during Wicket-7170 to ensure better test coverage.
The PR consists of several commits, that do a step by step migration:
- Migrated one test after the other from AnnotProxyFieldValueFactoryTest to AnnotProxyFieldValueFactoryDefaultCandidateTest
- After all tests are migrated: clean up empty tests (abstract AnnotProxyFieldValueFactoryTest, JakartaInjectAnnotProxyFieldValueFactoryTest, SpringBeanAnnotProxyFieldValueFactoryTest), and unused beans / interfaces
- Rename AnnotProxyFieldValueFactoryDefaultCandidateTest to AnnotProxyFieldValueFactoryTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/wicket 7170 followup improve tests [wicket]
Posted by "hosea (via GitHub)" <gi...@apache.org>.
hosea commented on code in PR #1312:
URL: https://github.com/apache/wicket/pull/1312#discussion_r2570142494
##########
wicket-spring/src/test/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryDefaultCandidateTest.java:
##########
@@ -61,37 +150,47 @@ public void shouldCreateProxyForUniqueDefaultCandidate_beanNameAmbiguous(final O
assertSame(defaultCandidate, beanByClassLocator.locateProxyTarget());
}
-
private static Stream<Object> beans() {
return Stream.of(new SpringBeanInjectable(), new JakartaInjectInjectable());
}
+
/**
- * Test creation fails with null springcontextlocator
+ * Mock for an object with some Jakarta-Inject annotations
*/
- @Test
- public void testNullContextLocator()
- {
- Assertions.assertThrows(IllegalArgumentException.class, () -> new AnnotProxyFieldValueFactory(null));
- }
-
Review Comment:
This test will be added later again when migrating corresponding test from AnnotProxyFieldFactoryTest...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/wicket 7170 followup improve tests [wicket]
Posted by "hosea (via GitHub)" <gi...@apache.org>.
hosea closed pull request #1312: Feature/wicket 7170 followup improve tests
URL: https://github.com/apache/wicket/pull/1312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org