You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by hx...@apache.org on 2019/06/26 13:20:36 UTC

[incubator-iotdb] branch feature_async_close_tsfile updated: remove unused fields in TsFileIOWriter

This is an automated email from the ASF dual-hosted git repository.

hxd pushed a commit to branch feature_async_close_tsfile
in repository https://gitbox.apache.org/repos/asf/incubator-iotdb.git


The following commit(s) were added to refs/heads/feature_async_close_tsfile by this push:
     new 425280c  remove unused fields in TsFileIOWriter
     new ddb2901  Merge branch 'feature_async_close_tsfile' of github.com:apache/incubator-iotdb into feature_async_close_tsfile
425280c is described below

commit 425280cab2381c678bcad958f6d982b8b4afcda1
Author: xiangdong huang <sa...@gmail.com>
AuthorDate: Wed Jun 26 21:20:00 2019 +0800

    remove unused fields in TsFileIOWriter
---
 .../apache/iotdb/tsfile/write/writer/TsFileIOWriter.java   | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/TsFileIOWriter.java b/tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/TsFileIOWriter.java
index aa5961f..6d18683 100644
--- a/tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/TsFileIOWriter.java
+++ b/tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/TsFileIOWriter.java
@@ -27,7 +27,6 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.TreeMap;
-import java.util.concurrent.atomic.AtomicLong;
 import org.apache.iotdb.tsfile.common.conf.TSFileConfig;
 import org.apache.iotdb.tsfile.common.constant.StatisticConstant;
 import org.apache.iotdb.tsfile.file.MetaMarker;
@@ -58,8 +57,6 @@ import org.slf4j.LoggerFactory;
  */
 public class TsFileIOWriter {
 
-  private File file;
-
   public static final byte[] magicStringBytes;
   private static final Logger LOG = LoggerFactory.getLogger(TsFileIOWriter.class);
 
@@ -107,14 +104,14 @@ public class TsFileIOWriter {
    * data in the TsFileOutput matches the given metadata list
    *
    * @param out the target output
-   * @param ChunkGroupMetaDataList existing chunkgroups' metadata
+   * @param chunkGroupMetaDataList existing chunkgroups' metadata
    * @throws IOException if I/O error occurs
    */
-  public TsFileIOWriter(TsFileOutput out, List<ChunkGroupMetaData> ChunkGroupMetaDataList)
+  public TsFileIOWriter(TsFileOutput out, List<ChunkGroupMetaData> chunkGroupMetaDataList)
       throws IOException {
     this.out = out;
-    this.chunkGroupMetaDataList = ChunkGroupMetaDataList;
-    if (ChunkGroupMetaDataList.isEmpty()) {
+    this.chunkGroupMetaDataList = chunkGroupMetaDataList;
+    if (chunkGroupMetaDataList.isEmpty()) {
       startFile();
     }
   }
@@ -338,7 +335,8 @@ public class TsFileIOWriter {
   }
 
   /**
-   * close the outputStream or file channel.
+   * close the outputStream or file channel without writing FileMetadata.
+   * This is just used for Testing.
    */
   public void close() throws IOException {
     canWrite = false;