You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "aresliharris (via GitHub)" <gi...@apache.org> on 2023/04/12 22:22:35 UTC

[GitHub] [guacamole-client] aresliharris opened a new pull request, #831: Use header instead of the http parameter for session/tunnels//protocol

aresliharris opened a new pull request, #831:
URL: https://github.com/apache/guacamole-client/pull/831

   Hello,
   
   This change hides the authentication token from the http parameter by using the predefined header "Guacamole-Token" instead for the following API call.
   
   `GET /api/session/tunnels/<tunnel ID>/protocol?token=<token>`
   
   <img width="838" alt="image" src="https://user-images.githubusercontent.com/124109426/231598825-83acc8e9-0753-477d-8475-36ddcbeebcea.png">
   
   Related Jira: https://issues.apache.org/jira/browse/GUACAMOLE-956


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [guacamole-client] aresliharris closed pull request #831: Use header instead of the http parameter for session/tunnels//protocol

Posted by "aresliharris (via GitHub)" <gi...@apache.org>.
aresliharris closed pull request #831: Use  header instead of the http parameter for session/tunnels/<tunnel ID>/protocol
URL: https://github.com/apache/guacamole-client/pull/831


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [guacamole-client] jmuehlner commented on pull request #831: Use header instead of the http parameter for session/tunnels//protocol

Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on PR #831:
URL: https://github.com/apache/guacamole-client/pull/831#issuecomment-1506044344

   @aresliharris Thanks for the contribution. All commits (and the PR name as well) should be tagged with the ticket number e.g. `GUACAMOLE-956: Do the things.`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [guacamole-client] aresliharris commented on pull request #831: Use header instead of the http parameter for session/tunnels//protocol

Posted by "aresliharris (via GitHub)" <gi...@apache.org>.
aresliharris commented on PR #831:
URL: https://github.com/apache/guacamole-client/pull/831#issuecomment-1506060737

   Closing this one as a [new PR](https://github.com/apache/guacamole-client/pull/832) was created based on the format that @jmuehlner suggested. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org