You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Jibing-Li (via GitHub)" <gi...@apache.org> on 2023/01/31 01:20:31 UTC
[GitHub] [doris] Jibing-Li opened a new pull request, #16268: [improvement](session variable)Add enable_file_cache session variable.
Jibing-Li opened a new pull request, #16268:
URL: https://github.com/apache/doris/pull/16268
# Proposed changes
Issue Number: close #xxx
## Problem summary
Add enable_file_cache session variable, so that we can close file cache without restart BE.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1409664506
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1411809408
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1409903609
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1409917783
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1411387750
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1409676937
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1409722124
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1410146634
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1410057766
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1409609837
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1411809481
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #16268:
URL: https://github.com/apache/doris/pull/16268#discussion_r1091410963
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -675,6 +676,9 @@ public class SessionVariable implements Serializable, Writable {
@VariableMgr.VarAttr(name = TWO_PHASE_READ_OPT_LIMIT_THRESHOLD)
public long twoPhaseReadLimitThreshold = 512;
+ @VariableMgr.VarAttr(name = ENABLE_FILE_CACHE)
Review Comment:
```suggestion
@VariableMgr.VarAttr(name = ENABLE_FILE_CACHE, needForward = true)
```
##########
be/src/vec/exec/format/orc/vorc_reader.h:
##########
@@ -70,11 +70,12 @@ class OrcReader : public GenericReader {
OrcReader(RuntimeProfile* profile, const TFileScanRangeParams& params,
const TFileRangeDesc& range, const std::vector<std::string>& column_names,
- size_t batch_size, const std::string& ctz, IOContext* io_ctx);
+ size_t batch_size, const std::string& ctz, IOContext* io_ctx,
+ bool enable_file_cache = true);
OrcReader(const TFileScanRangeParams& params, const TFileRangeDesc& range,
const std::vector<std::string>& column_names, const std::string& ctz,
- IOContext* io_ctx);
+ IOContext* io_ctx, bool enable_file_cache = true);
Review Comment:
better move `enable_file_cache` into `IOContext`
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -675,6 +676,9 @@ public class SessionVariable implements Serializable, Writable {
@VariableMgr.VarAttr(name = TWO_PHASE_READ_OPT_LIMIT_THRESHOLD)
public long twoPhaseReadLimitThreshold = 512;
+ @VariableMgr.VarAttr(name = ENABLE_FILE_CACHE)
Review Comment:
Please update the doc: https://doris.apache.org/zh-CN/docs/dev/advanced/variables
en and zh-CN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by github-actions.
github-actions[bot] commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1409871213
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #16268:
URL: https://github.com/apache/doris/pull/16268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16268:
URL: https://github.com/apache/doris/pull/16268#issuecomment-1409641065
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.46 seconds
load time: 492 seconds
storage size: 17122979831 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230131021143_clickbench_pr_87372.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org