[jira] [Commented] (MRELEASE-346) Refactor MavenExecutor out into some shared component (e.g. Invoker)

["Slawomir Jaranowski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRELEASE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469216#comment-17469216 ] 

Slawomir Jaranowski commented on MRELEASE-346:
----------------------------------------------

There are two implementations of {{org.apache.maven.shared.release.exec.MavenExecutor}}
- {{org.apache.maven.shared.release.exec.ForkedMavenExecutor}}
- {{org.apache.maven.shared.release.exec.InvokerMavenExecutor}}

By default {{InvokerMavenExecutor}} is used, so {{ForkedMavenExecutor}} and {{AbstractReleaseMojo#mavenExecutorId}} params can be removed.

Maybe it is good time to do it in milestone version.
It will break some of compatibility. 

> Refactor MavenExecutor out into some shared component (e.g. Invoker)
> --------------------------------------------------------------------
>
>                 Key: MRELEASE-346
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-346
>             Project: Maven Release Plugin
>          Issue Type: Task
>          Components: perform, prepare, stage
>    Affects Versions: 2.0-beta-7
>            Reporter: Benjamin Bentmann
>            Priority: Major
>
> The code from the package {{org.apache.maven.shared.release.exec}} is not very specific to the release job but basically duplicates functionality from the maven-invoker. Ideally this stuff would merge someday.
>  
> See: [https://github.com/apache/maven-release/tree/maven-release-3.0.0-M2/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec] 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)