You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ap...@apache.org on 2025/12/08 16:05:26 UTC

(arrow) branch main updated: GH-48176: [C++][Parquet] Fix arrow-ipc-message-internal-test failure (#48166)

This is an automated email from the ASF dual-hosted git repository.

apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 01bc1bd979 GH-48176: [C++][Parquet] Fix arrow-ipc-message-internal-test failure (#48166)
01bc1bd979 is described below

commit 01bc1bd979f51a6f77013855c3194159f9a87f0b
Author: Vishwanatha-HD <11...@users.noreply.github.com>
AuthorDate: Mon Dec 8 21:35:20 2025 +0530

    GH-48176: [C++][Parquet] Fix arrow-ipc-message-internal-test failure (#48166)
    
    **Rationale for this change**
    
    Fix `arrow-ipc-message-internal-test` on big endian systems by passing endianness explicitly.
    
    **Are these changes tested?**
    
    Yes. The changes are tested on s390x arch to make sure things are working fine. The fix is also tested on x86 arch, to make sure there is no new regression introduced.
    
    **Are there any user-facing changes?**
    
    No
    
    * GitHub main Issue link: #48151
    * GitHub Issue: #48176
    
    Lead-authored-by: Vishwanatha-HD <Vi...@ibm.com>
    Co-authored-by: Antoine Pitrou <an...@python.org>
    Signed-off-by: Antoine Pitrou <an...@python.org>
---
 cpp/src/arrow/ipc/message_internal_test.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/cpp/src/arrow/ipc/message_internal_test.cc b/cpp/src/arrow/ipc/message_internal_test.cc
index 1114f55517..87ce3de39c 100644
--- a/cpp/src/arrow/ipc/message_internal_test.cc
+++ b/cpp/src/arrow/ipc/message_internal_test.cc
@@ -47,7 +47,7 @@ TEST(TestMessageInternal, TestByteIdentical) {
   std::vector<std::shared_ptr<Field>> fields = {f0, f1};
   std::shared_ptr<KeyValueMetadata> metadata =
       KeyValueMetadata::Make({"key_1", "key_2"}, {"key_1_value", "key_2_value"});
-  auto schema = ::arrow::schema({f0}, metadata);
+  auto schema = ::arrow::schema({f0}, Endianness::Little, metadata);
 
   // Serialize the Schema to a Buffer
   std::shared_ptr<Buffer> out_buffer;
@@ -73,6 +73,7 @@ TEST(TestMessageInternal, TestByteIdentical) {
       0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x66, 0x30, 0x00, 0x00, 0x08, 0x00,
       0x0C, 0x00, 0x08, 0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01,
       0x40, 0x00, 0x00, 0x00};
+
   Buffer expected_buffer(expected, sizeof(expected));
 
   AssertBufferEqual(expected_buffer, *out_buffer);