[jira] [Commented] (CASSANDRA-13321) Add a checksum component for the sstable metadata (-Statistics.db) file

["Jason Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-13321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905094#comment-15905094 ] 

Jason Brown commented on CASSANDRA-13321:
-----------------------------------------

The changes look good on the whole, but there are some failing unit tests.

Minor nits:
- maybe rename {{IMetadataSerializer#writeMetadata()}} to {{IMetadataSerializer#serializeWithChecksum{}}} as it was confusing to me the difference between {{#serialize{}}} and {{#writeMetadata()}}. Also, a javadoc comment would be a nice addition.
- I'm not sure it's necessary (or possible), but since two files are being modified in {{#MetadataSerializer#rewriteSSTableMetadata()}}, is it possible or useful to use a transaction? That way we can guard against only one of the files being written or renamed correctly.

> Add a checksum component for the sstable metadata (-Statistics.db) file
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-13321
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13321
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 4.x
>
>
> Since we keep important information in the sstable metadata file now, we should add a checksum component for it. One danger being if a bit gets flipped in repairedAt we could consider the sstable repaired when it is not.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)