You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/27 22:12:34 UTC
[GitHub] [spark] itholic commented on a diff in pull request #37305: [SPARK-39881][PYTHON] Fix erroneous check for black and reenable black validation.
itholic commented on code in PR #37305:
URL: https://github.com/apache/spark/pull/37305#discussion_r931622919
##########
python/pyspark/pandas/tests/data_type_ops/test_boolean_ops.py:
##########
@@ -226,10 +226,10 @@ def test_rpow(self):
b_pser, b_psser = pdf["bool"], psdf["bool"]
# float is returned always in pandas-on-Spark
- self.assert_eq((1 ** b_pser).astype(float), 1 ** b_psser)
- self.assert_eq(0.1 ** b_pser, 0.1 ** b_psser)
+ self.assert_eq((1**b_pser).astype(float), 1**b_psser)
+ self.assert_eq(0.1**b_pser, 0.1**b_psser)
self.assertRaises(TypeError, lambda: "x" ** b_psser)
- self.assertRaises(TypeError, lambda: True ** b_psser)
+ self.assertRaises(TypeError, lambda: True**b_psser)
self.assertRaises(TypeError, lambda: datetime.date(1994, 1, 1) ** b_psser)
self.assertRaises(TypeError, lambda: datetime.datetime(1994, 1, 1) ** b_psser)
Review Comment:
Yeah, I understand about the priority but just wonder why Black did:
```diff
- self.assertRaises(TypeError, lambda: True ** b_psser)
+ self.assertRaises(TypeError, lambda: True**b_psser)
```
but didn't
```diff
- self.assertRaises(TypeError, lambda: datetime.date(1994, 1, 1) ** b_psser)
- self.assertRaises(TypeError, lambda: datetime.datetime(1994, 1, 1) ** b_psser)
+ self.assertRaises(TypeError, lambda: datetime.date(1994, 1, 1)**b_psser)
+ self.assertRaises(TypeError, lambda: datetime.datetime(1994, 1, 1)**b_psser)
```
It seems like just inconsistence behavior from Black, so maybe we can just keep is as is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org