You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Apache9 (via GitHub)" <gi...@apache.org> on 2026/06/24 03:52:17 UTC
[PR] HBASE-30253 Do not add/remove peer between tests in TestBulkLoadRepli… [hbase]
Apache9 opened a new pull request, #8404:
URL: https://github.com/apache/hbase/pull/8404
…cation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30253 Do not add/remove peer between tests in TestBulkLoadRepli… [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 merged PR #8404:
URL: https://github.com/apache/hbase/pull/8404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30253 Do not add/remove peer between tests in TestBulkLoadRepli… [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #8404:
URL: https://github.com/apache/hbase/pull/8404#discussion_r3464996785
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestBulkLoadReplication.java:
##########
@@ -162,13 +162,19 @@ private static void startThirdCluster() throws Exception {
}
@BeforeEach
- public void resetBulkLoadCount() throws Exception {
- // removing the peer and adding again causing the previously completed bulk load jobs getting
- // submitted again, so here we override the setUpBase and tearDownBase to not adding/removing
- // peers between each tests, we will add peers in beforeAll
+ @Override
+ public void setUpBase() throws Exception {
+ // Removing the peer and adding it back causes previously completed bulk-load jobs to be
+ // resubmitted. Override setUpBase/tearDownBase so we do not add/remove peers between tests;
+ // peers are added once in @BeforeAll.
BULK_LOADS_COUNT = new AtomicInteger(0);
}
+ @Override
+ public void tearDownBase() throws Exception {
+ // do not remove PEER_ID2
+ }
Review Comment:
We’d better add an `@AfterEach` annotation to maintain consistency here, even though it’s equivalent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30253 Do not add/remove peer between tests in TestBulkLoadRepli… [hbase]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #8404:
URL: https://github.com/apache/hbase/pull/8404#discussion_r3464427836
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestBulkLoadReplication.java:
##########
@@ -130,8 +130,8 @@ public static void setUpBeforeAll() throws Exception {
ReplicationPeerConfig peer1Config = getPeerConfigForCluster(UTIL1);
ReplicationPeerConfig peer2Config = getPeerConfigForCluster(UTIL2);
ReplicationPeerConfig peer3Config = getPeerConfigForCluster(UTIL3);
- // Setup following topology: "1 <-> 2 <-> 3", 1 -> 2 will be added by setUpBase method in parent
- // class
+ // Setup following topology: "1 <-> 2 <-> 3"
Review Comment:
Grammar: this comment should use the verb form “Set up …” (two words) for readability and consistency with other comments.
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestBulkLoadReplication.java:
##########
@@ -162,13 +162,19 @@ private static void startThirdCluster() throws Exception {
}
@BeforeEach
- public void resetBulkLoadCount() throws Exception {
+ @Override
+ public void setUpBase() throws Exception {
// removing the peer and adding again causing the previously completed bulk load jobs getting
// submitted again, so here we override the setUpBase and tearDownBase to not adding/removing
// peers between each tests, we will add peers in beforeAll
Review Comment:
Grammar in this comment is a bit unclear (e.g., “removing … causing”, “to not adding/removing”, “between each tests”). Rewording it will make the intent easier to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org