[GitHub] [tvm] driazati commented on a diff in pull request #14779: fix: use arm on demand instead of spot

["driazati (via GitHub)" <gi...@apache.org>]

driazati commented on code in PR #14779:
URL: https://github.com/apache/tvm/pull/14779#discussion_r1186482407


##########
ci/jenkins/templates/utils/macros.j2:
##########
@@ -33,7 +33,7 @@ sh(
 {% set test_dir_name = name.replace(":", "").replace(" ", "-").replace("-", "_")|string %}
 def {{ method_name }}(node_type='{{ node }}-SPOT', on_demand=false) {
   if ({{ condition }}) {
-    if (on_demand==true) {
+    if (on_demand==true or 'ARM' in node_type) {

Review Comment:
   without being wrapped in `{{ ... }}` this happens inside groovy at runtime, so `in` and `or` don't work
   ```suggestion
       if (on_demand==true || node_type.contains('ARM')) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org