You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/10 00:13:38 UTC
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5270: [IMPORTANT] Query traces with tags as condition
wu-sheng commented on a change in pull request #5270:
URL: https://github.com/apache/skywalking/pull/5270#discussion_r467646700
##########
File path: oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/base/InfluxInsertRequest.java
##########
@@ -68,6 +71,15 @@ public InfluxInsertRequest addFieldAsTag(String fieldName, String tagName) {
return this;
}
+ public InfluxInsertRequest tags(List<SpanTag> tags) {
+ if (!Objects.isNull(tags) && !tags.isEmpty()) {
+ for (final SpanTag tag : tags) {
+ builder.addField(tag.getKey(), tag.getValue());
Review comment:
Tag keys could be duplicated as it is in the different spans, what will happen here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org