You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "kriti-sc (via GitHub)" <gi...@apache.org> on 2026/02/18 18:52:41 UTC
[PR] fixes #2770 [iggy]
kriti-sc opened a new pull request, #2771:
URL: https://github.com/apache/iggy/pull/2771
Closes #2770
## Rationale
The sink_connector! and source_connector! macros export a generic open symbol, which collides with POSIX open() in a cdylib. As a result, calls to open() resolve to the plugin’s FFI function instead of libc, causing argument misinterpretation and a segfault.
## What changed?
Renamed the exported FFI symbols to avoid collision with libc/POSIX names:
open → iggy_sink_open / iggy_source_open
close → iggy_sink_close / iggy_source_close
consume → iggy_sink_consume
handle → iggy_source_handle
version → iggy_sink_version / iggy_source_version
## Local Execution
- Passed - Originally implemented for the Delta Sink Connector. This change fixed the segfault.
## AI Usage
If AI tools were used, please answer:
1. Which tools? Claude Code
2. Scope of usage? Autocomplete
3. How did you verify the generated code works correctly? The Delta Sink for which this change was originally implemented stopped giving the segmentation error and ran successfully
4. Can you explain every line of the code if asked? Yes
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(connectors): don't use posix function names as FFI interface [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #2771:
URL: https://github.com/apache/iggy/pull/2771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixes #2770 [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #2771:
URL: https://github.com/apache/iggy/pull/2771#issuecomment-3922588829
rename title to `fix(connectors): don't use posix function names as FFI interface`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(connectors): don't use posix function names as FFI interface [iggy]
Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz commented on PR #2771:
URL: https://github.com/apache/iggy/pull/2771#issuecomment-3922788915
AFAIR these are part of e.g. Flink ecosystem, not our connectors runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(connectors): don't use posix function names as FFI interface [iggy]
Posted by "kriti-sc (via GitHub)" <gi...@apache.org>.
kriti-sc commented on PR #2771:
URL: https://github.com/apache/iggy/pull/2771#issuecomment-3922674832
Is the connector SDK used by external connectors in `iggy/foreign/java/external-processors` like the Flink and Pinot connectors? Please excuse the naive question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(connectors): don't use posix function names as FFI interface [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2771:
URL: https://github.com/apache/iggy/pull/2771#issuecomment-3922836250
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2771?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.50000%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.91%. Comparing base ([`f8566c5`](https://app.codecov.io/gh/apache/iggy/commit/f8566c546e561aaf94625a855ae93f210067ab3a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7827635`](https://app.codecov.io/gh/apache/iggy/commit/7827635f1aad30d588d4de31c19f09cdae853369?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2771?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [core/connectors/sdk/src/source.rs](https://app.codecov.io/gh/apache/iggy/pull/2771?src=pr&el=tree&filepath=core%2Fconnectors%2Fsdk%2Fsrc%2Fsource.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3Nkay9zcmMvc291cmNlLnJz) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2771?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2771 +/- ##
============================================
- Coverage 68.34% 67.91% -0.43%
+ Complexity 656 585 -71
============================================
Files 741 741
Lines 62165 62165
Branches 58578 58578
============================================
- Hits 42484 42217 -267
- Misses 17571 17860 +289
+ Partials 2110 2088 -22
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2771/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [rust](https://app.codecov.io/gh/apache/iggy/pull/2771/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.35% <87.50%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2771?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/connectors/runtime/src/main.rs](https://app.codecov.io/gh/apache/iggy/pull/2771?src=pr&el=tree&filepath=core%2Fconnectors%2Fruntime%2Fsrc%2Fmain.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3J1bnRpbWUvc3JjL21haW4ucnM=) | `86.09% <100.00%> (ø)` | |
| [core/connectors/runtime/src/sink.rs](https://app.codecov.io/gh/apache/iggy/pull/2771?src=pr&el=tree&filepath=core%2Fconnectors%2Fruntime%2Fsrc%2Fsink.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3J1bnRpbWUvc3JjL3NpbmsucnM=) | `69.27% <100.00%> (+0.55%)` | :arrow_up: |
| [core/connectors/runtime/src/source.rs](https://app.codecov.io/gh/apache/iggy/pull/2771?src=pr&el=tree&filepath=core%2Fconnectors%2Fruntime%2Fsrc%2Fsource.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3J1bnRpbWUvc3JjL3NvdXJjZS5ycw==) | `66.29% <100.00%> (ø)` | |
| [core/connectors/sdk/src/sink.rs](https://app.codecov.io/gh/apache/iggy/pull/2771?src=pr&el=tree&filepath=core%2Fconnectors%2Fsdk%2Fsrc%2Fsink.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3Nkay9zcmMvc2luay5ycw==) | `76.15% <100.00%> (ø)` | |
| [core/connectors/sdk/src/source.rs](https://app.codecov.io/gh/apache/iggy/pull/2771?src=pr&el=tree&filepath=core%2Fconnectors%2Fsdk%2Fsrc%2Fsource.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3Nkay9zcmMvc291cmNlLnJz) | `65.71% <50.00%> (-16.43%)` | :arrow_down: |
... and [25 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2771/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(connectors): don't use posix function names as FFI interface [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #2771:
URL: https://github.com/apache/iggy/pull/2771#issuecomment-3922808291
These external connectors are just using the Iggy Java SDK client (TCP protocol).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org