[jira] [Commented] (HBASE-11382) Adding unit test for HBASE-10964 (Delete mutation is not consistent with Put wrt timestamp)

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038277#comment-14038277 ] 

Anoop Sam John commented on HBASE-11382:
----------------------------------------

Thanks for taking a look at these area.

{code}
+    delete.setTimestamp(ts);
+    delete.deleteColumn(FAMILY, QUALIFIER);
+    Assert.assertEquals(ts, delete.getTimeStamp());
{code}
It is not worth to only assert ts by getting from Delete object.  Simple setter getter check only.  The issue was, when the delete obj is constructed with a ts, the KVs getting added to obj (every call like deleteColumn will add kv objects inside familyMap in Delete) were not honoring this ts.  So u need to assert the TS in these KVs.

Also need license header for the new file.

As long as it is not spinning mini cluster, new test class addition is ok in this area.

> Adding unit test for HBASE-10964 (Delete mutation is not consistent with Put wrt timestamp)
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11382
>                 URL: https://issues.apache.org/jira/browse/HBASE-11382
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>            Priority: Minor
>         Attachments: HBASE-11382.patch
>
>
> Adding a small unit test for verifying that delete mutation is honoring timestamp of delete object.



--
This message was sent by Atlassian JIRA
(v6.2#6252)