You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/01/11 23:00:46 UTC

[GitHub] [systemds] Shafaq-Siddiqi commented on pull request #1139: [WIP][SYSTEMDS-2782] Built-in mdedup

Shafaq-Siddiqi commented on pull request #1139:
URL: https://github.com/apache/systemds/pull/1139#issuecomment-758278337


   LGTM. Thank you @OlgaOvcharenko for the contribution. During the merge, I fixed some formatting issues, simplified the map() code for accepting two parameters. I have temporarily fixed the Spark tests by specifying the matrix indices inside the component function call. It seems to be a bug in size propagation I will create a JIRA report for this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org