You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "jasirkt (via GitHub)" <gi...@apache.org> on 2023/03/08 14:13:52 UTC
[GitHub] [lucene] jasirkt opened a new pull request, #12196: Fix Slop Issue in MultiFieldQueryParser
jasirkt opened a new pull request, #12196:
URL: https://github.com/apache/lucene/pull/12196
### Description
This change fixes #12195.
In Lucene 5.4.0 [this commit](https://github.com/apache/lucene/commit/962313b83ba9c69379e1f84dffc881a361713ce9#diff-e10af886a9a7ba5221abfcfbe9dc057d2cee39d3b875e0eb2843085979ecdf5e) introduced some changes for immutability of queries. setBoost() function was replaced with new BoostQuery(), but BoostQuery is not handled in setSlop function. This pull request adds the handling of BoostQuery in setSlop() function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jasirkt commented on pull request #12196: Fix Slop Issue in MultiFieldQueryParser
Posted by "jasirkt (via GitHub)" <gi...@apache.org>.
jasirkt commented on PR #12196:
URL: https://github.com/apache/lucene/pull/12196#issuecomment-1460262146
@rmuir I've added a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #12196: Fix Slop Issue in MultiFieldQueryParser
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #12196:
URL: https://github.com/apache/lucene/pull/12196#issuecomment-1460451659
Thank you for the fix @jasirkt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #12196: Fix Slop Issue in MultiFieldQueryParser
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #12196:
URL: https://github.com/apache/lucene/pull/12196#issuecomment-1460225168
thank you for tracking this down: is there a simple unit test we could add for the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #12196: Fix Slop Issue in MultiFieldQueryParser
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir merged PR #12196:
URL: https://github.com/apache/lucene/pull/12196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jasirkt commented on pull request #12196: Fix Slop Issue in MultiFieldQueryParser
Posted by "jasirkt (via GitHub)" <gi...@apache.org>.
jasirkt commented on PR #12196:
URL: https://github.com/apache/lucene/pull/12196#issuecomment-1461195438
Welcome @rmuir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org