You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/07/07 18:30:58 UTC

[GitHub] [maven-archetype] newur edited a comment on pull request #65: [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace

newur edited a comment on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-875833742


   @elharo 
   
   I don't see what you try to achieve or what your reasoning is here. However, the call to `.normalizeWhitespace()` is rather new and I assume it was added to 'get the test green'. So undoing the normalize is bringing the test back to the status quo - which was a stronger test anyway!
   
   You can see it here: https://github.com/apache/maven-archetype/commit/bf7961805ea56cdad7e138f47098aacccb314db8#diff-db4ddee9a40aadf3fab866c350ca950397f69b630de05a126f0265e2136cc070


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org