You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by KulykRoman <gi...@git.apache.org> on 2017/07/06 16:47:01 UTC
[GitHub] drill pull request #869: DRILL-4511: Refresh over empty folder results in er...
GitHub user KulykRoman opened a pull request:
https://github.com/apache/drill/pull/869
DRILL-4511: Refresh over empty folder results in error, we need a better error message
- Added unit test for "Table does not exist" situation in case of empty directory or incorrect table.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KulykRoman/drill DRILL-4511
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #869
----
commit dce3313774a62917320fa7e8aff9948b50cf85a2
Author: Roman Kulyk <ro...@gmail.com>
Date: 2017-07-06T15:27:34Z
DRILL-4511: Refresh over empty folder results in error, we need a better error message
- Added unit test for "Table does not exist" situation in case of empty directory or incorrect table.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #869: DRILL-4511: Add unit test for "Table does not exist...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/869
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #869: DRILL-4511: Add unit test for "Table does not exist" situa...
Posted by KulykRoman <gi...@git.apache.org>.
Github user KulykRoman commented on the issue:
https://github.com/apache/drill/pull/869
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #869: DRILL-4511: Add unit test for "Table does not exist" situa...
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/869
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #869: DRILL-4511: Add unit test for "Table does not exist...
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/869#discussion_r126133035
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java ---
@@ -207,6 +207,31 @@ public void testAbsentPluginOrWorkspaceError() throws Exception {
.go();
}
+ @Test //DRILL-4511
+ public void testTableDoesNotExistError() throws Exception {
--- End diff --
1. Please split into two tests.
2. You can use to `ExecTest.getTempDir()` to get unique temporary directory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---