[GitHub] [pinot] swaminathanmanish commented on pull request #10722: Making segment replacement request apis backwards compatible

["swaminathanmanish (via GitHub)" <gi...@apache.org>]

swaminathanmanish commented on PR #10722:
URL: https://github.com/apache/pinot/pull/10722#issuecomment-1536477722

   > AFAIK we need to add `@JsonCreator` whenever we have more than 1 constructor in a class that has to be instantiated by Jackson
   The integration test that uses these constructors passed. So looks like @JsonCreator takes effect by default if you have only one constructor whose params are annotated with JsonProperty. I tried adding JsonProperty to the other constructor and ran into failures (multiple creators). So I dropped the JsonProperty for the other annotation. 
   
   I guess its better to be explicit and annotate JsonProperty for both constructors and make one as @JsonCreator. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org