You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "deardeng (via GitHub)" <gi...@apache.org> on 2025/04/17 13:18:47 UTC
[PR] [fix](cloud) Some APIs cannot check if cluster_name is empty [doris]
deardeng opened a new pull request, #50148:
URL: https://github.com/apache/doris/pull/50148
### What problem does this PR solve?
due to https://github.com/apache/doris/pull/49775
but some api cant check cluster name,
1. Cloud Management The request may not have passed in the cluster_name in the inventory logic
2. sql node mode also not pass cluster_name to ms, so in cloud use sql `ALTER SYSTEM ADD BACKEND ip:host` will return err, not have cluster name
```
```
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Some APIs cannot check if cluster_name is empty [doris]
Posted by "deardeng (via GitHub)" <gi...@apache.org>.
deardeng commented on PR #50148:
URL: https://github.com/apache/doris/pull/50148#issuecomment-2817969683
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Some APIs cannot check if cluster_name is empty [doris]
Posted by "deardeng (via GitHub)" <gi...@apache.org>.
deardeng commented on PR #50148:
URL: https://github.com/apache/doris/pull/50148#issuecomment-2812876553
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Some APIs cannot check if cluster_name is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50148:
URL: https://github.com/apache/doris/pull/50148#issuecomment-2817871080
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Some APIs cannot check if cluster_name is empty [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #50148:
URL: https://github.com/apache/doris/pull/50148#issuecomment-2812875581
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Some APIs cannot check if cluster_name is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50148:
URL: https://github.com/apache/doris/pull/50148#issuecomment-2812920861
TeamCity cloud ut coverage result:
Function Coverage: 83.00% (1089/1312)
Line Coverage: 66.12% (18184/27500)
Region Coverage: 65.57% (8962/13668)
Branch Coverage: 55.44% (4832/8716)
Coverage Report: http://coverage.selectdb-in.cc/coverage/75a28d6097b66bd27a96242784561db8f574570f_75a28d6097b66bd27a96242784561db8f574570f_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Some APIs cannot check if cluster_name is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50148:
URL: https://github.com/apache/doris/pull/50148#issuecomment-2818006866
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Some APIs cannot check if cluster_name is empty [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #50148:
URL: https://github.com/apache/doris/pull/50148#discussion_r2052136218
##########
cloud/src/resource-manager/resource_manager.h:
##########
@@ -114,7 +114,7 @@ class ResourceManager {
const std::vector<NodeInfo>& to_del);
bool check_cluster_params_valid(const ClusterPB& cluster, std::string* err,
Review Comment:
add comment for modify_nodes check_cluster_params_valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Some APIs cannot check if cluster_name is empty [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #50148:
URL: https://github.com/apache/doris/pull/50148#discussion_r2052103588
##########
cloud/src/resource-manager/resource_manager.h:
##########
@@ -114,7 +114,7 @@ class ResourceManager {
const std::vector<NodeInfo>& to_del);
bool check_cluster_params_valid(const ClusterPB& cluster, std::string* err,
- bool check_master_num);
+ bool check_master_num, bool check_cluster_name = false);
Review Comment:
seem not reasonable for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Some APIs cannot check if cluster_name is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50148:
URL: https://github.com/apache/doris/pull/50148#issuecomment-2817985216
TeamCity cloud ut coverage result:
Function Coverage: 82.93% (1093/1318)
Line Coverage: 65.66% (18263/27814)
Region Coverage: 65.07% (9047/13904)
Branch Coverage: 55.08% (4875/8850)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f46444949770ccc8ab4e92430be9c2485c419448_f46444949770ccc8ab4e92430be9c2485c419448_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Some APIs cannot check if cluster_name is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50148:
URL: https://github.com/apache/doris/pull/50148#issuecomment-2817871036
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Some resource APIs should not check if cluster_name is empty [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou merged PR #50148:
URL: https://github.com/apache/doris/pull/50148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org