You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/18 14:35:55 UTC
[GitHub] [airflow] chenglongyan opened a new pull request, #26461: Support Equal To filter for state is None on webui
chenglongyan opened a new pull request, #26461:
URL: https://github.com/apache/airflow/pull/26461
closes: #26427
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chenglongyan closed pull request #26461: Support empty field filter on webui.
Posted by GitBox <gi...@apache.org>.
chenglongyan closed pull request #26461: Support empty field filter on webui.
URL: https://github.com/apache/airflow/pull/26461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #26461: Support Equal To filter for state is None on webui
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26461:
URL: https://github.com/apache/airflow/pull/26461#discussion_r975370492
##########
airflow/www/utils.py:
##########
@@ -541,6 +541,13 @@ def apply(self, query, value):
return super().apply(query, value)
+class StateAwareFilterMixin:
Review Comment:
There's nothing particular about this filter to the state column is there?
If not, it would be helpful to add this to most other columns too please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chenglongyan commented on pull request #26461: Support empty field filter on webui.
Posted by GitBox <gi...@apache.org>.
chenglongyan commented on PR #26461:
URL: https://github.com/apache/airflow/pull/26461#issuecomment-1253660705
Need to add support for all fields...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chenglongyan commented on a diff in pull request #26461: Support Equal To filter for state is None on webui
Posted by GitBox <gi...@apache.org>.
chenglongyan commented on code in PR #26461:
URL: https://github.com/apache/airflow/pull/26461#discussion_r976449717
##########
airflow/www/utils.py:
##########
@@ -541,6 +541,13 @@ def apply(self, query, value):
return super().apply(query, value)
+class StateAwareFilterMixin:
Review Comment:
Nothing, I just didn't think it through, thanks @ashb .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org