You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/09/21 13:06:50 UTC
[GitHub] [accumulo] milleruntime opened a new pull request, #2947: Drop FateAdmin classes
milleruntime opened a new pull request, #2947:
URL: https://github.com/apache/accumulo/pull/2947
Follow on for #2914 . The Fate operations code now lives in way too many places. The FateAdmin class should be dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #2947: Drop FateAdmin classes
Posted by GitBox <gi...@apache.org>.
dlmarion commented on PR #2947:
URL: https://github.com/apache/accumulo/pull/2947#issuecomment-1253711124
> this would preserve compatibility from anyone coming from 1.10.x or 2.0.x to 2.1.0.
Do we need to preserve compatibility between major versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2947: Drop FateAdmin classes
Posted by GitBox <gi...@apache.org>.
EdColeman commented on PR #2947:
URL: https://github.com/apache/accumulo/pull/2947#issuecomment-1253704710
Would it make sense for 2.1 if both classes were marked as deprecated and then point to the replacement?
I think the history was that the master version was / is deprecated because of the renaming to manager - I thought we were scheduled to fully remove master in 3.0 - but we need to leave some references in 2.1 because of semver?
I think the ideal way to handle this would be to have them print a deprecated warning and then call the equivalent new functionality - this would preserve compatibility from anyone coming from 1.10.x or 2.0.x to 2.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2947: Drop FateAdmin classes
Posted by GitBox <gi...@apache.org>.
EdColeman commented on PR #2947:
URL: https://github.com/apache/accumulo/pull/2947#issuecomment-1253719312
Between major, no so 2.x to 3.x allows incompatible API changes.
Minor, so 2.0 to 2.1, new functionality can be added in a backward compatible manor.
Not sure that FateAdmin is strictly considered public API, but that does not mean that we cannot preserve compatibility even if we "could" just drop it as people migrate to 2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #2947: Drop FateAdmin classes
Posted by GitBox <gi...@apache.org>.
dlmarion commented on PR #2947:
URL: https://github.com/apache/accumulo/pull/2947#issuecomment-1255393724
I have no objection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2947: Drop FateAdmin classes
Posted by GitBox <gi...@apache.org>.
milleruntime commented on PR #2947:
URL: https://github.com/apache/accumulo/pull/2947#issuecomment-1253726149
FateAdmin is not API and is a server utility. There has been the deprecated message since version 1.6.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #2947: Drop FateAdmin classes
Posted by GitBox <gi...@apache.org>.
milleruntime merged PR #2947:
URL: https://github.com/apache/accumulo/pull/2947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2947: Drop FateAdmin classes
Posted by GitBox <gi...@apache.org>.
milleruntime commented on PR #2947:
URL: https://github.com/apache/accumulo/pull/2947#issuecomment-1255360675
If there are no objections to dropping this class in 2.1, I will merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2947: Drop FateAdmin classes
Posted by GitBox <gi...@apache.org>.
milleruntime commented on PR #2947:
URL: https://github.com/apache/accumulo/pull/2947#issuecomment-1253685846
Left off the Project label but I think we should drop this in 2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org