You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by "jkevan (via GitHub)" <gi...@apache.org> on 2023/03/20 15:46:09 UTC
[GitHub] [unomi] jkevan opened a new pull request, #593: UNOMI-748, UNOMI-749: more improvements for merge system: updateWithS…
jkevan opened a new pull request, #593:
URL: https://github.com/apache/unomi/pull/593
…cript to reassign past sessions/events, fix inconstency in sessions profileId, use schedulerService to support asynchronous update of past browsing data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] jkevan merged pull request #593: UNOMI-748, UNOMI-749: more improvements for merge system: updateWithS…
Posted by "jkevan (via GitHub)" <gi...@apache.org>.
jkevan merged PR #593:
URL: https://github.com/apache/unomi/pull/593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] jkevan commented on a diff in pull request #593: UNOMI-748, UNOMI-749: more improvements for merge system: updateWithS…
Posted by "jkevan (via GitHub)" <gi...@apache.org>.
jkevan commented on code in PR #593:
URL: https://github.com/apache/unomi/pull/593#discussion_r1145839125
##########
services/src/main/java/org/apache/unomi/services/impl/segments/SegmentServiceImpl.java:
##########
@@ -163,7 +158,6 @@ public void postConstruct() throws IOException {
}
bundleContext.addBundleListener(this);
initializeTimer();
- loadScripts();
Review Comment:
Yes I moved the painless script loading in the persistence service :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] dgriffon commented on a diff in pull request #593: UNOMI-748, UNOMI-749: more improvements for merge system: updateWithS…
Posted by "dgriffon (via GitHub)" <gi...@apache.org>.
dgriffon commented on code in PR #593:
URL: https://github.com/apache/unomi/pull/593#discussion_r1145736373
##########
services/src/main/java/org/apache/unomi/services/impl/segments/SegmentServiceImpl.java:
##########
@@ -163,7 +158,6 @@ public void postConstruct() throws IOException {
}
bundleContext.addBundleListener(this);
initializeTimer();
- loadScripts();
Review Comment:
Is it related to the current PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org