You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2014/05/22 01:11:42 UTC
Review Request 21793: [HELIX-439] Support thresholding for job
success/failure
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21793/
-----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
Bugs: HELIX-439
Repository: helix-git
Description
-------
commit efed8848fee9eeda847336f3de93f7ce4458b6a4
Author: Kanak Biscuitwala <ka...@apache.org>
Date: Wed May 21 16:10:17 2014 -0700
[HELIX-439] Support thresholding for job success/failure
:100644 100644 90e3cfc... b166da1... M helix-core/src/main/java/org/apache/helix/task/JobConfig.java
:100644 100644 547ba48... 4ddab1a... M helix-core/src/main/java/org/apache/helix/task/TaskConfig.java
:100644 100644 457f0e0... 849f339... M helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java
:100644 100644 5b27fb6... 537f287... M helix-core/src/main/java/org/apache/helix/task/Workflow.java
:100644 100644 5e12f19... af5882c... M helix-core/src/main/java/org/apache/helix/task/beans/JobBean.java
:100644 100644 eedccb5... 97ecfc0... M helix-core/src/main/java/org/apache/helix/task/beans/TaskBean.java
:100644 100644 b2928e6... 7041db8... M helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/task/JobConfig.java 90e3cfc
helix-core/src/main/java/org/apache/helix/task/TaskConfig.java 547ba48
helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java 457f0e0
helix-core/src/main/java/org/apache/helix/task/Workflow.java 5b27fb6
helix-core/src/main/java/org/apache/helix/task/beans/JobBean.java 5e12f19
helix-core/src/main/java/org/apache/helix/task/beans/TaskBean.java eedccb5
helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java b2928e6
Diff: https://reviews.apache.org/r/21793/diff/
Testing
-------
Existing tests pass, new tests check that thresholding works as expected.
Thanks,
Kanak Biscuitwala
Re: Review Request 21793: [HELIX-439] Support thresholding for job
success/failure
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21793/#review43744
-----------------------------------------------------------
Ship it!
Ship It!
- Zhen Zhang
On May 21, 2014, 11:11 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21793/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 11:11 p.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-439
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit efed8848fee9eeda847336f3de93f7ce4458b6a4
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Wed May 21 16:10:17 2014 -0700
>
> [HELIX-439] Support thresholding for job success/failure
>
> :100644 100644 90e3cfc... b166da1... M helix-core/src/main/java/org/apache/helix/task/JobConfig.java
> :100644 100644 547ba48... 4ddab1a... M helix-core/src/main/java/org/apache/helix/task/TaskConfig.java
> :100644 100644 457f0e0... 849f339... M helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java
> :100644 100644 5b27fb6... 537f287... M helix-core/src/main/java/org/apache/helix/task/Workflow.java
> :100644 100644 5e12f19... af5882c... M helix-core/src/main/java/org/apache/helix/task/beans/JobBean.java
> :100644 100644 eedccb5... 97ecfc0... M helix-core/src/main/java/org/apache/helix/task/beans/TaskBean.java
> :100644 100644 b2928e6... 7041db8... M helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/task/JobConfig.java 90e3cfc
> helix-core/src/main/java/org/apache/helix/task/TaskConfig.java 547ba48
> helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java 457f0e0
> helix-core/src/main/java/org/apache/helix/task/Workflow.java 5b27fb6
> helix-core/src/main/java/org/apache/helix/task/beans/JobBean.java 5e12f19
> helix-core/src/main/java/org/apache/helix/task/beans/TaskBean.java eedccb5
> helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java b2928e6
>
> Diff: https://reviews.apache.org/r/21793/diff/
>
>
> Testing
> -------
>
> Existing tests pass, new tests check that thresholding works as expected.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>
Re: Review Request 21793: [HELIX-439] Support thresholding for job
success/failure
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21793/#review43747
-----------------------------------------------------------
Ship it!
Ship It!
- Kishore Gopalakrishna
On May 21, 2014, 11:11 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21793/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 11:11 p.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-439
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit efed8848fee9eeda847336f3de93f7ce4458b6a4
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Wed May 21 16:10:17 2014 -0700
>
> [HELIX-439] Support thresholding for job success/failure
>
> :100644 100644 90e3cfc... b166da1... M helix-core/src/main/java/org/apache/helix/task/JobConfig.java
> :100644 100644 547ba48... 4ddab1a... M helix-core/src/main/java/org/apache/helix/task/TaskConfig.java
> :100644 100644 457f0e0... 849f339... M helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java
> :100644 100644 5b27fb6... 537f287... M helix-core/src/main/java/org/apache/helix/task/Workflow.java
> :100644 100644 5e12f19... af5882c... M helix-core/src/main/java/org/apache/helix/task/beans/JobBean.java
> :100644 100644 eedccb5... 97ecfc0... M helix-core/src/main/java/org/apache/helix/task/beans/TaskBean.java
> :100644 100644 b2928e6... 7041db8... M helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/task/JobConfig.java 90e3cfc
> helix-core/src/main/java/org/apache/helix/task/TaskConfig.java 547ba48
> helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java 457f0e0
> helix-core/src/main/java/org/apache/helix/task/Workflow.java 5b27fb6
> helix-core/src/main/java/org/apache/helix/task/beans/JobBean.java 5e12f19
> helix-core/src/main/java/org/apache/helix/task/beans/TaskBean.java eedccb5
> helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java b2928e6
>
> Diff: https://reviews.apache.org/r/21793/diff/
>
>
> Testing
> -------
>
> Existing tests pass, new tests check that thresholding works as expected.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>