You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/06/13 13:23:23 UTC

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9528: sched/group: Ensure that the setting of tg_members if safe in SMP

pkarashchenko commented on code in PR #9528:
URL: https://github.com/apache/nuttx/pull/9528#discussion_r1228126760


##########
sched/group/group_join.c:
##########
@@ -208,9 +218,12 @@ int group_join(FAR struct pthread_tcb_s *tcb)
     {
       return ret;
     }
+#else
+  flags = enter_critical_section();

Review Comment:
   Should it be a spinlock or critical section?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org