[GitHub] [poi] MariusVolkhart commented on a change in pull request #197: Modify test utility class to compile on OpenJ9

[GitBox <gi...@apache.org>]

MariusVolkhart commented on a change in pull request #197:
URL: https://github.com/apache/poi/pull/197#discussion_r523114918



##########
File path: src/integrationtest/org/apache/poi/stress/HeapDump.java
##########
@@ -42,7 +43,17 @@ Licensed to the Apache Software Foundation (ASF) under one or more
     public static void dumpHeap(String fileName, boolean live) throws IOException {
         // initialize hotspot diagnostic MBean
         initHotspotMBean();
-        hotspotMBean.dumpHeap(fileName, live);
+        throw new NotImplementedException("Developer: You need to uncomment the corresponding line here.");

Review comment:
       Done! @pjfanning mind taking another look? I tested w/ OpenJ9 11 and OpenJDK 16




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org