[GitHub] [airflow] o-nikolas commented on issue #33146: Add an example for custom executor

["o-nikolas (via GitHub)" <gi...@apache.org>]

o-nikolas commented on issue #33146:
URL: https://github.com/apache/airflow/issues/33146#issuecomment-1669945264

   > Yeah @o-nikolas - I think that would be a good addition as part of the AWS executor to write a short "howto" based on the learnings . That would be truly completing AIP-51 finally.
   
   @potiuk, yupp totally agree! It's been a task I had on the project board from the very beginning :)  #27934
   
   Hoping to get to it soon now that the CLI stuff is close to resolution. I've just been distracted by some triggerer changes I'm trying to get merged in time for 2.7.0
   
   > Shall the community not recommend directly inheriting from [BaseExecutor](https://github.com/apache/airflow/blob/main/airflow/executors/base_executor.py)?
   
   We do indeed recommend this (or _will_ do so soon anyways :smile:), the BaseExecutor is the public interface to create your own executor, it's the thing that we'll make a harder promise on backwards compatibility.
   
   > yes this is a power user functionality and I would not be surprise if AWS do
   
   > class AwsEcsExecutor(CeleryExecutor):
   
   We are indeed working on a new ECS executor (which will be a great new example of implementing a third part executor) but we do **not** inherit from the CeleryExecutor. Celery executor is an executor from a different provider (very recently) it is not part of core and does not guarantee as much backwards compat as the BaseExecutor public Interface in core Airflow. Nor is it a very good starting point since it's quite a complicated executor and comes with lots of machinery that you don't need or would complicate your executor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org