You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/18 04:46:00 UTC
[GitHub] [arrow-datafusion] liukun4515 opened a new issue, #2259: division decimal: lose precision when convert i128 to f64
liukun4515 opened a new issue, #2259:
URL: https://github.com/apache/arrow-datafusion/issues/2259
But now I find a bug in the arithmetic operation. https://github.com/apache/arrow-datafusion/blob/c91efc27658e58264c4f346a5cfdec8810179e90/datafusion/physical-expr/src/expressions/binary.rs#L302 and https://github.com/apache/arrow-datafusion/blob/c91efc27658e58264c4f346a5cfdec8810179e90/datafusion/physical-expr/src/expressions/binary.rs#L307
In the divide method, we may lose of precision by converting the `i128` to `f64`.
We use the `f64` to store the larger range of data, but we lose the precision.
I will try to figure out this issue and resolve this.
_Originally posted by @liukun4515 in https://github.com/apache/arrow-datafusion/pull/2233#discussion_r851859744_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #2259: division decimal: lose precision when convert i128 to f64
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #2259:
URL: https://github.com/apache/arrow-datafusion/issues/2259#issuecomment-1638049597
I wonder if this is now completed 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] viirya commented on issue #2259: division decimal: lose precision when convert i128 to f64
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on issue #2259:
URL: https://github.com/apache/arrow-datafusion/issues/2259#issuecomment-1638538497
I think the code using f64 for decimal division is out-of-dated for a while. We are using i128 directly to process it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on issue #2259: division decimal: lose precision when convert i128 to f64
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #2259:
URL: https://github.com/apache/arrow-datafusion/issues/2259#issuecomment-1101090730
related to #122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #2259: division decimal: lose precision when convert i128 to f64
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #2259: division decimal: lose precision when convert i128 to f64
URL: https://github.com/apache/arrow-datafusion/issues/2259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org