You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "fjtirado (via GitHub)" <gi...@apache.org> on 2024/12/17 15:21:49 UTC
[PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
fjtirado opened a new pull request, #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166
Fix https://github.com/apache/incubator-kie-kogito-apps/issues/2165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166#discussion_r1893892372
##########
data-index/data-index-common/src/main/java/org/kie/kogito/index/CommonUtils.java:
##########
@@ -18,15 +18,56 @@
*/
package org.kie.kogito.index;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
import java.util.Set;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import graphql.schema.idl.SchemaParser;
+import graphql.schema.idl.TypeDefinitionRegistry;
+
public class CommonUtils {
public static final int ERROR_STATE = 5;
private static final Set<String> finalStates = Set.of("Completed", "Aborted");
+ private static final Logger logger = LoggerFactory.getLogger(CommonUtils.class);
Review Comment:
I prefer logger, according to this https://stackoverflow.com/a/12069687/16843807, which refers to the proper section of Java coding style. The rationale is that Logger or other object references that are not inmutable or used as a service/helper (which is the case of logger), should be in lowercase. They try to reflect that with the . convention rule, which is ambigous, but I think the spirit should be clear. In the case of logger, which is inmutable is the reference, not necesarily the object being referenced (there is a long argument of a guy that study which loggers are mutable and which ones are inmutable)
I know we are using both in our codebase (according to the taste of each developer), so my policy is to not change the ones already existing, but if adding a new one, use the lowercase form (because I think using uppercase to something that is not really a constant is confusing, although Im not going to ask anyone that prefers the uppercase form to start using the lowercase approach)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166#discussion_r1893892372
##########
data-index/data-index-common/src/main/java/org/kie/kogito/index/CommonUtils.java:
##########
@@ -18,15 +18,56 @@
*/
package org.kie.kogito.index;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
import java.util.Set;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import graphql.schema.idl.SchemaParser;
+import graphql.schema.idl.TypeDefinitionRegistry;
+
public class CommonUtils {
public static final int ERROR_STATE = 5;
private static final Set<String> finalStates = Set.of("Completed", "Aborted");
+ private static final Logger logger = LoggerFactory.getLogger(CommonUtils.class);
Review Comment:
I prefer logger, according to this https://stackoverflow.com/a/12069687/16843807, which refers to the proper section of Java coding style
I know we are using both in our codebase (according to the taste of each developer), so my policy is to not change the ones already existing, but if adding a new one, use the lowercase form
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166#issuecomment-2555889371
**PR job** `#14` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2166 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/14/display/redirect
**Test results:**
- PASSED: 1463
- FAILED: 7
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/14/testReport/org.kie.kogito.it.jobs/ProcessTimerIT/PR_check___Build_projects___testDeleteTimerCycle/">PR check / Build projects / org.kie.kogito.it.jobs.ProcessTimerIT.testDeleteTimerCycle</a></summary>
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.test.resources.JobServiceCompositeQuarkusTestResource
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/14/testReport/org.kie.kogito.addons.quarkus.data.index.it/InfinispanQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.InfinispanQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexInfinispanHttpQuarkusTestResource
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/14/testReport/org.kie.kogito.addons.quarkus.data.index.it/InfinispanQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.InfinispanQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexInfinispanHttpQuarkusTestResource
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/14/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexMongoDBHttpQuarkusTestResource
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/14/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexMongoDBHttpQuarkusTestResource
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/14/testReport/org.kie.kogito.addons.quarkus.data.index.it/PostgreSQLQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexPostgreSqlHttpQuarkusTestResource
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/14/testReport/org.kie.kogito.addons.quarkus.data.index.it/PostgreSQLQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexPostgreSqlHttpQuarkusTestResource
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166#issuecomment-2552086538
**PR job** `#9` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2166 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/display/redirect
**Test results:**
- PASSED: 1643
- FAILED: 37
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.inmemory/KogitoDevServiceTest/testDataIndexDevService/">org.kie.kogito.index.inmemory.KogitoDevServiceTest.testDataIndexDevService</a></summary>
io.quarkus.builder.BuildException: Build failure: Build failed due to errors<br/> [error]: Build step org.kie.kogito.quarkus.serverless.workflow.deployment.ServerlessWorkflowDevServicesProcessor#startDataIndexDevService threw an exception: java.lang.RuntimeException: Failed to start Kogito Data Index Dev Services<br/> at org.kie.kogito.quarkus.workflow.deployment.AbstractDevServicesProcessor.startDataIndexDevService(AbstractDevServicesProcessor.java:129)<br/> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)<br/> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)<br/> at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)<br/> at java.base/java.lang.reflect.Method.invoke(Method.java:568)<br/> at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)<br/> at io.quarkus.builder.BuildContext.run(BuildContext.java:256)<br/> at org.jbo
ss.threads.ContextHandler$1.runWith(ContextHandler.java:18)<br/> at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)<br/> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)<br/> at java.base/java.lang.Thread.run(Thread.java:840)<br/> at org.jboss.threads.JBossThread.run(JBossThread.java:501)<br/>Caused by: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image org.kie.kogito/data-index-service-inmemory:999-SNAPSHOT<br/> at org.kie.kogito.quarkus.workflow.deployment.AbstractDevServicesProcessor.lambda$startDataIndex$2(AbstractDevServicesProcessor.java:203)<br/> at java.base/java.util.Optional.orElseGet(Optional.java:364)<br/> at org.kie.kogito.quarkus.workflow.deployment.AbstractDevServicesProcessor.startDataIndex(AbstractDevServicesProcessor.java:208)<br/> at org.kie.kogito.quarkus.workflow.deployment.AbstractDevServicesProcessor.startDataIndexDevS
ervice(AbstractDevServicesProcessor.java:119)<br/> ... 11 more<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image org.kie.kogito/data-index-service-inmemory:999-SNAPSHOT<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359)<br/> at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:330)<br/> at org.kie.kogito.quarkus.workflow.deployment.AbstractDevServicesProcessor.lambda$startDataIndex$2(AbstractDevServicesProcessor.java:199)<br/> ... 14 more<br/>Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception<br/> at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:344)<br/> ... 16 more<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container<br/> at org.testcontainers.containers
.GenericContainer.tryStart(GenericContainer.java:563)<br/> at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:354)<br/> at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)<br/> ... 17 more<br/>Caused by: java.lang.IllegalStateException: Wait strategy failed. Container exited with code 1<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:533)<br/> ... 19 more<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for URL to be accessible (http://172.18.0.1:54892/q/health/ready should return HTTP [200])<br/> at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.waitUntilReady(HttpWaitStrategy.java:320)<br/> at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)<br/> at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:909)<br/> at org.
testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:500)<br/> ... 19 more<br/>Caused by: org.rnorth.ducttape.TimeoutException: Timeout waiting for result with exception<br/> at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:54)<br/> at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.waitUntilReady(HttpWaitStrategy.java:252)<br/> ... 22 more<br/>Caused by: java.lang.RuntimeException: java.net.ConnectException: Connection refused<br/> at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.lambda$null$6(HttpWaitStrategy.java:312)<br/> at org.rnorth.ducttape.ratelimits.RateLimiter.doWhenReady(RateLimiter.java:27)<br/> at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.lambda$waitUntilReady$7(HttpWaitStrategy.java:257)<br/> at org.rnorth.ducttape.unreliables.Unreliables.lambda$retryUntilSuccess$0(Unreliables.java:43)<br/> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)<br/> at j
ava.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)<br/> at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)<br/> at java.base/java.lang.Thread.run(Thread.java:840)<br/>Caused by: java.net.ConnectException: Connection refused<br/> at java.base/sun.nio.ch.Net.connect0(Native Method)<br/> at java.base/sun.nio.ch.Net.connect(Net.java:579)<br/> at java.base/sun.nio.ch.Net.connect(Net.java:568)<br/> at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:593)<br/> at java.base/java.net.Socket.connect(Socket.java:633)<br/> at java.base/java.net.Socket.connect(Socket.java:583)<br/> at java.base/sun.net.NetworkClient.doConnect(NetworkClient.java:183)<br/> at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:533)<br/> at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:638)<br/> at java.base/sun.net.www.http.HttpClient.<init>(HttpClient.java:281)<br/> at java.base/sun.net.www
.http.HttpClient.New(HttpClient.java:386)<br/> at java.base/sun.net.www.http.HttpClient.New(HttpClient.java:408)<br/> at java.base/sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1309)<br/> at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1242)<br/> at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1128)<br/> at java.base/sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:1057)<br/> at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.lambda$null$6(HttpWaitStrategy.java:274)<br/> ... 7 more<br/>
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.inmemory/ProcessDataIndexInMemoryIT/testProcessInstanceEvents/">org.kie.kogito.index.inmemory.ProcessDataIndexInMemoryIT.testProcessInstanceEvents</a></summary>
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.DataIndexInMemoryQuarkusTestResource
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.postgresql/ProcessDataIndexPostgreSqlHttpIT/testProcessInstanceEvents/">org.kie.kogito.index.postgresql.ProcessDataIndexPostgreSqlHttpIT.testProcessInstanceEvents</a></summary>
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexPostgreSqlHttpQuarkusTestResource
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.postgresql/ProcessDataIndexPostgreSqlKafkaIT/testProcessInstanceEvents/">org.kie.kogito.index.postgresql.ProcessDataIndexPostgreSqlKafkaIT.testProcessInstanceEvents</a></summary>
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.kafka.DataIndexPostgreSqlQuarkusKafkaTestResource
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index/ProcessDataIndexPostgreSqlIT/testProcessInstanceEvents/">org.kie.kogito.index.ProcessDataIndexPostgreSqlIT.testProcessInstanceEvents</a></summary>
Failed to load ApplicationContext for [WebMergedContextConfiguration@1692d173 testClass = org.kie.kogito.index.ProcessDataIndexPostgreSqlIT, locations = [], classes = [org.kie.kogito.KogitoApplication], contextInitializerClasses = [org.kie.kogito.index.spring.KogitoServiceRandomPortSpringTestResource, org.kie.kogito.index.spring.DataIndexPostgreSqlSpringTestResource], activeProfiles = [], propertySourceDescriptors = [], propertySourceProperties = ["org.springframework.boot.test.context.SpringBootTestContextBootstrapper=true", "server.port=0"], contextCustomizers = [org.springframework.boot.test.context.filter.ExcludeFilterContextCustomizer@6f1c29b7, org.springframework.boot.test.json.DuplicateJsonObjectContextCustomizerFactory$DuplicateJsonObjectContextCustomizer@2a7ed1f, org.springframework.boot.test.mock.mockito.MockitoContextCustomizer@0, org.springframework.boot.test.web.client.TestRestTemplateContextCustomizer@5456afaa, org.springframework.boot.test.autoconfigure.actuate.obse
rvability.ObservabilityContextCustomizerFactory$DisableObservabilityContextCustomizer@1f, org.springframework.boot.test.autoconfigure.properties.PropertyMappingContextCustomizer@0, org.springframework.boot.test.autoconfigure.web.servlet.WebDriverContextCustomizer@1787bc24, org.springframework.boot.test.context.SpringBootTestAnnotation@bf04646b], resourceBasePath = "src/main/webapp", contextLoader = org.springframework.boot.test.context.SpringBootContextLoader, parent = null]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.it.jobs/ProcessTimerIT/PR_check___Build_projects___testDeleteTimerCycle/">PR check / Build projects / org.kie.kogito.it.jobs.ProcessTimerIT.testDeleteTimerCycle</a></summary>
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.test.resources.JobServiceCompositeQuarkusTestResource
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/___/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.(?)</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.service/KeycloakInmemoryPostgreSqlIndexingServiceIT/testUnauthorizedUserAccess/">org.kie.kogito.index.service.KeycloakInmemoryPostgreSqlIndexingServiceIT.testUnauthorizedUserAccess</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.service/KeycloakPostgreSqlIndexingServiceIT/testUnauthorizedUserAccess/">org.kie.kogito.index.service.KeycloakPostgreSqlIndexingServiceIT.testUnauthorizedUserAccess</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.service/PostgreSqlIndexingServiceIT/___/">org.kie.kogito.index.service.PostgreSqlIndexingServiceIT.(?)</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingKafkaConsumerIT/testProcessInstanceEvent/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingKafkaConsumerIT.testProcessInstanceEvent</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.mapper/JobEntityMapperIT/testMapToModel/">org.kie.kogito.index.jdbc.mapper.JobEntityMapperIT.testMapToModel</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.query/H2JobEntityQueryIT/testJobQuery/">org.kie.kogito.index.jdbc.query.H2JobEntityQueryIT.testJobQuery</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.query/H2ProcessDefinitionEntityQueryIT/testProcessDefinitionQuery/">org.kie.kogito.index.jdbc.query.H2ProcessDefinitionEntityQueryIT.testProcessDefinitionQuery</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.query/H2ProcessInstanceEntityQueryIT/testProcessInstanceQuery/">org.kie.kogito.index.jdbc.query.H2ProcessInstanceEntityQueryIT.testProcessInstanceQuery</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.query/H2UserTaskInstanceEntityQueryIT/testUserTaskInstanceQuery/">org.kie.kogito.index.jdbc.query.H2UserTaskInstanceEntityQueryIT.testUserTaskInstanceQuery</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.query/PostgreSQLJobEntityQueryIT/testJobQuery/">org.kie.kogito.index.jdbc.query.PostgreSQLJobEntityQueryIT.testJobQuery</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.query/PostgreSQLProcessDefinitionEntityQueryIT/testProcessDefinitionQuery/">org.kie.kogito.index.jdbc.query.PostgreSQLProcessDefinitionEntityQueryIT.testProcessDefinitionQuery</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.query/PostgreSQLProcessInstanceEntityQueryIT/testProcessInstanceQuery/">org.kie.kogito.index.jdbc.query.PostgreSQLProcessInstanceEntityQueryIT.testProcessInstanceQuery</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.query/PostgreSQLUserTaskInstanceEntityQueryIT/testUserTaskInstanceQuery/">org.kie.kogito.index.jdbc.query.PostgreSQLUserTaskInstanceEntityQueryIT.testUserTaskInstanceQuery</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.storage/H2JobStorageIT/testJobEntity/">org.kie.kogito.index.jdbc.storage.H2JobStorageIT.testJobEntity</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.storage/PostgreSQLJobStorageIT/testJobEntity/">org.kie.kogito.index.jdbc.storage.PostgreSQLJobStorageIT.testJobEntity</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.storage/PostgreSQLProcessDefinitionStorageIT/testProcessDefinitionEntity/">org.kie.kogito.index.jdbc.storage.PostgreSQLProcessDefinitionStorageIT.testProcessDefinitionEntity</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.storage/PostgreSQLProcessInstanceStorageIT/testProcessInstanceErrorEvent/">org.kie.kogito.index.jdbc.storage.PostgreSQLProcessInstanceStorageIT.testProcessInstanceErrorEvent</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.jdbc.storage/PostgreSQLUserTaskInstanceStorageIT/testUserTaskInstanceEntity/">org.kie.kogito.index.jdbc.storage.PostgreSQLUserTaskInstanceStorageIT.testUserTaskInstanceEntity</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.postgresql.reporting/ProcessInstanceVariableMappingIT/testProcessInstanceVariableMapping/">org.kie.kogito.index.postgresql.reporting.ProcessInstanceVariableMappingIT.testProcessInstanceVariableMapping</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.index.postgresql.mapper/JobEntityMapperIT/testMapToModel/">org.kie.kogito.index.postgresql.mapper.JobEntityMapperIT.testMapToModel</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexPersistenceTest/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexPersistenceTest.testDataIndexAddon</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexPersistenceTest/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexPersistenceTest.testDataIndexAddon</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.addons.quarkus.data.index.it/PostgreSQLQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.addons.quarkus.data.index.it/PostgreSQLQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.addons.quarkus.data.index.it/InMemoryQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.InMemoryQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.addons.quarkus.data.index.it/InMemoryQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.InMemoryQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.addons.quarkus.data.index.it/PostgreSQLQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2166/9/testReport/org.kie.kogito.addons.quarkus.data.index.it/PostgreSQLQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede commented on code in PR #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166#discussion_r1893879010
##########
data-index/data-index-graphql/src/main/java/org/kie/kogito/index/graphql/AbstractGraphQLSchemaManager.java:
##########
@@ -69,8 +68,6 @@ public abstract class AbstractGraphQLSchemaManager implements GraphQLSchemaManag
private static final String UNABLE_TO_FIND_ERROR_MSG = "Unable to find the instance with %s %s";
- private static final Logger LOGGER = LoggerFactory.getLogger(AbstractGraphQLSchemaManager.class);
Review Comment:
see former example LOGGER here :smile:
##########
data-index/data-index-common/src/main/java/org/kie/kogito/index/CommonUtils.java:
##########
@@ -18,15 +18,56 @@
*/
package org.kie.kogito.index;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
import java.util.Set;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import graphql.schema.idl.SchemaParser;
+import graphql.schema.idl.TypeDefinitionRegistry;
+
public class CommonUtils {
public static final int ERROR_STATE = 5;
private static final Set<String> finalStates = Set.of("Completed", "Aborted");
+ private static final Logger logger = LoggerFactory.getLogger(CommonUtils.class);
Review Comment:
I'd prefer call his LOGGER
##########
data-index/data-index-graphql/src/main/java/org/kie/kogito/index/graphql/AbstractGraphQLSchemaManager.java:
##########
@@ -92,14 +92,17 @@ public void setup() {
(GraphQLInputObjectType) schema.getType("JobArgument"));
}
+ protected final void loadAdditionalMutations(Builder builder) {
+ mutations.stream().map(m -> m.mutations(this)).flatMap(map -> map.entrySet().stream())
Review Comment:
Maybe a log trace can help identify in the future which additional mutations were loaded in current server. :thinking:
##########
data-index/data-index-mutations/data-index-shared-output-mutation/src/main/java/org/kie/kogito/index/mutations/OutputGraphQLMutationProvider.java:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.kie.kogito.index.mutations;
+
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+
+import org.kie.kogito.index.CommonUtils;
+import org.kie.kogito.index.api.ExecuteArgs;
+import org.kie.kogito.index.graphql.AbstractGraphQLSchemaManager;
+import org.kie.kogito.index.graphql.GraphQLMutationsProvider;
+import org.kie.kogito.index.model.ProcessDefinition;
+import org.kie.kogito.index.model.ProcessDefinitionKey;
+import org.kie.kogito.index.model.ProcessInstance;
+import org.kie.kogito.index.storage.DataIndexStorageService;
+import org.kie.kogito.jackson.utils.JsonObjectUtils;
+import org.kie.kogito.jackson.utils.MergeUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.fasterxml.jackson.databind.JsonNode;
+
+import graphql.schema.DataFetcher;
+import graphql.schema.DataFetchingEnvironment;
+import graphql.schema.idl.TypeDefinitionRegistry;
+
+public class OutputGraphQLMutationProvider implements GraphQLMutationsProvider {
+
+ private static Logger logger = LoggerFactory.getLogger(OutputGraphQLMutationProvider.class);
Review Comment:
LOGGER ?
##########
data-index/data-index-service/data-index-service-common/src/main/java/org/kie/kogito/index/service/api/KogitoRuntimeClientImpl.java:
##########
@@ -72,6 +75,17 @@ class KogitoRuntimeClientImpl extends KogitoRuntimeCommonClient implements Kogit
private static final Logger LOGGER = LoggerFactory.getLogger(KogitoRuntimeClientImpl.class);
Review Comment:
LOGGER :heart:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede commented on code in PR #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166#discussion_r1893964341
##########
data-index/data-index-common/src/main/java/org/kie/kogito/index/CommonUtils.java:
##########
@@ -18,15 +18,56 @@
*/
package org.kie.kogito.index;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
import java.util.Set;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import graphql.schema.idl.SchemaParser;
+import graphql.schema.idl.TypeDefinitionRegistry;
+
public class CommonUtils {
public static final int ERROR_STATE = 5;
private static final Set<String> finalStates = Set.of("Completed", "Aborted");
+ private static final Logger logger = LoggerFactory.getLogger(CommonUtils.class);
Review Comment:
"although Im not going to ask anyone that prefers the uppercase form to start using the lowercase approach"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166#discussion_r1893892372
##########
data-index/data-index-common/src/main/java/org/kie/kogito/index/CommonUtils.java:
##########
@@ -18,15 +18,56 @@
*/
package org.kie.kogito.index;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
import java.util.Set;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import graphql.schema.idl.SchemaParser;
+import graphql.schema.idl.TypeDefinitionRegistry;
+
public class CommonUtils {
public static final int ERROR_STATE = 5;
private static final Set<String> finalStates = Set.of("Completed", "Aborted");
+ private static final Logger logger = LoggerFactory.getLogger(CommonUtils.class);
Review Comment:
I prefer logger, according to this https://stackoverflow.com/a/12069687/16843807, which refers to the proper section of Java coding style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado closed pull request #2166: [Fix #2165] Adding custom mutations
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado merged PR #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166#discussion_r1888707365
##########
data-index/data-index-graphql/src/main/java/org/kie/kogito/index/graphql/AbstractGraphQLSchemaManager.java:
##########
@@ -141,7 +141,7 @@ public ProcessDefinition getProcessDefinition(DataFetchingEnvironment env) {
return cacheService.getProcessDefinitionStorage().get(new ProcessDefinitionKey(source.getProcessId(), source.getVersion()));
}
- protected String getServiceUrl(String endpoint, String processId) {
+ public String getServiceUrl(String endpoint, String processId) {
Review Comment:
Im going to refactor this, service URL should not be part of the interface of KogitoRuntimeClient (at least not for new methods)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166#discussion_r1893892372
##########
data-index/data-index-common/src/main/java/org/kie/kogito/index/CommonUtils.java:
##########
@@ -18,15 +18,56 @@
*/
package org.kie.kogito.index;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
import java.util.Set;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import graphql.schema.idl.SchemaParser;
+import graphql.schema.idl.TypeDefinitionRegistry;
+
public class CommonUtils {
public static final int ERROR_STATE = 5;
private static final Set<String> finalStates = Set.of("Completed", "Aborted");
+ private static final Logger logger = LoggerFactory.getLogger(CommonUtils.class);
Review Comment:
I prefer logger, according to this https://stackoverflow.com/a/12069687/16843807, which refers to the proper section of Java coding style. The rationale is that Logger or other object references that are not inmutable or used as a service/helper (which is the case of logger), should be in lowercase. They try to reflect that with the . convention rule, which is ambigous, but I think the spirit should be clear. In the case of logger, which is inmutable is the reference, not necesarily the object being referenced (there is a long argument of a guy that study which loggers are mutable and which ones are inmutable. This path is dangerous, because if we switch from an imutable to a mutable, we will have to change case. therefore I prefer to focus on the usage, we are not ussing logger as it was a literal constant or a collection of constants, but as a helper service to log, therefore it is irrelevant if the object internal state does not change when we call info or if we forgot to add
the final to the variable holding the reference)
I know we are using both in our codebase (according to the taste of each developer), so my policy is to not change the ones already existing, but if adding a new one, use the lowercase form (because I think using uppercase to something that is not really a constant is confusing, although Im not going to ask anyone that prefers the uppercase form to start using the lowercase approach)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2165] Adding custom mutations [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2166:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2166#discussion_r1893892372
##########
data-index/data-index-common/src/main/java/org/kie/kogito/index/CommonUtils.java:
##########
@@ -18,15 +18,56 @@
*/
package org.kie.kogito.index;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
import java.util.Set;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import graphql.schema.idl.SchemaParser;
+import graphql.schema.idl.TypeDefinitionRegistry;
+
public class CommonUtils {
public static final int ERROR_STATE = 5;
private static final Set<String> finalStates = Set.of("Completed", "Aborted");
+ private static final Logger logger = LoggerFactory.getLogger(CommonUtils.class);
Review Comment:
I prefer logger, according to this https://stackoverflow.com/a/12069687/16843807, which refers to the proper section of Java coding style. The rationale is that Logger or other object references that are not inmutable or used as a service/helper (which is the case of logger), should be in lowercase. They try to reflect that with the . convention rule, which is ambigous, but I think the spirit should be clear. In the case of logger, which is inmutable is the reference, not necesarily the object being referenced (there is a long argument of a guy that study which loggers are mutable and which ones are inmutable, I prefer to focus on the usage, we are not ussing logger as it was a literal constant or a collection of constants)
I know we are using both in our codebase (according to the taste of each developer), so my policy is to not change the ones already existing, but if adding a new one, use the lowercase form (because I think using uppercase to something that is not really a constant is confusing, although Im not going to ask anyone that prefers the uppercase form to start using the lowercase approach)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org