You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Ivan A. Veselovsky (JIRA)" <ji...@apache.org> on 2012/12/18 13:06:19 UTC

[jira] [Commented] (MAPREDUCE-4762) repair test org.apache.hadoop.mapreduce.security.token.TestDelegationTokenRenewal

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534843#comment-13534843 ] 

Ivan A. Veselovsky commented on MAPREDUCE-4762:
-----------------------------------------------

The class DelegationTokenRenewal as well as corresponding test were removed in trunk and branch-2 as a result of fix MAPREDUCE-4861 .
So, the patches for trunk and branch-2 are no longer valid.
The patch for branch-0.23 is still valid, though.
                
> repair test org.apache.hadoop.mapreduce.security.token.TestDelegationTokenRenewal
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4762
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4762
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Ivan A. Veselovsky
>         Attachments: MAPREDUCE-4762--b.patch, MAPREDUCE-4762-branch-0.23--b.patch, MAPREDUCE-4762-trunk.patch
>
>
> The test org.apache.hadoop.mapreduce.security.token.TestDelegationTokenRenewal is @Ignor-ed. 
> Due to that several classes in package org.apache.hadoop.mapreduce.security.token have zero unit-test coverage.
> The problem is that the test assumed that class org.apache.hadoop.mapreduce.security.token.TestDelegationTokenRenewal.Renewer is used as a custom implementation of the org.apache.hadoop.security.token.TokenRenewer service, but that did not happen, because this custom service implementation was not registered. 
> We solved this problem by using special classloader that is invoked to find the resource META-INF/services/org.apache.hadoop.security.token.TokenRenewer , and supplies some custom content for it. This way the custom service implementation gets instantiated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira