You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by ji...@apache.org on 2026/06/11 06:47:52 UTC

(rocketmq-clients) branch master updated: [Go] Fix forwardToDeadLetterQueueLater incorrectly calling ackMessage instead of forwardToDeadLetterQueue (#1266)

This is an automated email from the ASF dual-hosted git repository.

RongtongJin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git


The following commit(s) were added to refs/heads/master by this push:
     new 323fe200 [Go] Fix forwardToDeadLetterQueueLater incorrectly calling ackMessage instead of forwardToDeadLetterQueue (#1266)
323fe200 is described below

commit 323fe20087f9637ea04b0f229582e0a8e8f30285
Author: guyinyou <36...@users.noreply.github.com>
AuthorDate: Thu Jun 11 14:47:48 2026 +0800

    [Go] Fix forwardToDeadLetterQueueLater incorrectly calling ackMessage instead of forwardToDeadLetterQueue (#1266)
    
    forwardToDeadLetterQueueLater was calling ackMessage0 and ackMessageLater
    instead of forwardToDeadLetterQueue0 and forwardToDeadLetterQueueLater,
    which would cause messages destined for the dead letter queue to be
    silently acknowledged and lost.
    
    Co-authored-by: guyinyou <gu...@alibaba-inc.com>
---
 golang/process_queue.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/golang/process_queue.go b/golang/process_queue.go
index 0af768d9..1109a9c7 100644
--- a/golang/process_queue.go
+++ b/golang/process_queue.go
@@ -177,10 +177,10 @@ func (dpq *defaultProcessQueue) forwardToDeadLetterQueueLater(mv *MessageView, a
 			if err := recover(); err != nil {
 				dpq.consumer.cli.log.Errorf("[Bug] Failed to schedule message change invisible duration request, mq=%s, messageId=%s, "+
 					"clientId=%s", dpq.mqstr, messageId, clientId)
-				dpq.ackMessageLater(mv, 1+attempt, callback)
+				dpq.forwardToDeadLetterQueueLater(mv, 1+attempt, callback)
 			}
 		}()
-		dpq.ackMessage0(mv, attempt, callback)
+		dpq.forwardToDeadLetterQueue0(mv, attempt, callback)
 	})
 }