You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/11/04 18:26:49 UTC
Re: Review Request 39102: Added documentation for JSON resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 5:26 p.m.)
Review request for mesos, Adam B and Neil Conway.
Bugs: MESOS-2467
https://issues.apache.org/jira/browse/MESOS-2467
Repository: mesos
Description
-------
Added documentation for JSON resources.
Diffs (updated)
-----
docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447
docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
Diff: https://reviews.apache.org/r/39102/diff/
Testing
-------
Viewed the relevant documentation sections ('Attributes and Resources' & 'Configuration') using the mesos-website-container: https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 39102: Added documentation for JSON resources.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/#review105237
-----------------------------------------------------------
Looks great, but we need to fix the consistency issue between the configuration.md and flags.cpp, and not recommend ``cat resources.txt``.
docs/attributes-resources.md (lines 45 - 49)
<https://reviews.apache.org/r/39102/#comment163757>
Provide at least one example with a role
docs/attributes-resources.md (line 104)
<https://reviews.apache.org/r/39102/#comment163758>
Inconsistent spacing after ':'s
docs/attributes-resources.md (line 164)
<https://reviews.apache.org/r/39102/#comment163762>
Why ``cat resources.txt`` instead of `--resources=file:///path/to/resources.txt`?
docs/attributes-resources.md (line 166)
<https://reviews.apache.org/r/39102/#comment163763>
Note: the "default role" is set by `--default_role`
docs/configuration.md (line 1398)
<https://reviews.apache.org/r/39102/#comment163764>
Did you change src/slave/flags.cpp to match this new description?
docs/configuration.md (line 1406)
<https://reviews.apache.org/r/39102/#comment163765>
Other JSON flags have text like:
"The value could be a JSON formatted string of rules or a\n"
"file path containing the JSON formated rules used in the endpoints\n"
"firewall. Path must be of the form 'file:///path/to/file'\n"
"or '/path/to/file'.\n"
- Adam B
On Nov. 4, 2015, 9:26 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39102/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 9:26 a.m.)
>
>
> Review request for mesos, Adam B and Neil Conway.
>
>
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for JSON resources.
>
>
> Diffs
> -----
>
> docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447
> docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
>
> Diff: https://reviews.apache.org/r/39102/diff/
>
>
> Testing
> -------
>
> Viewed the relevant documentation sections ('Attributes and Resources' & 'Configuration') using the mesos-website-container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39102: Added documentation for JSON resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/#review105540
-----------------------------------------------------------
Bad patch!
Reviews applied: [39211, 39018]
Failed command: ./support/apply-review.sh -n -r 39018
Error:
2015-11-07 00:10:18 URL:https://reviews.apache.org/r/39018/diff/raw/ [45596/45596] -> "39018.patch" [1]
error: patch failed: src/common/resources.cpp:254
error: src/common/resources.cpp: patch does not apply
error: patch failed: src/tests/resources_tests.cpp:163
error: src/tests/resources_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 6, 2015, 7:41 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39102/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 7:41 p.m.)
>
>
> Review request for mesos, Adam B and Neil Conway.
>
>
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for JSON resources.
>
>
> Diffs
> -----
>
> docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447
> docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
> src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
>
> Diff: https://reviews.apache.org/r/39102/diff/
>
>
> Testing
> -------
>
> Viewed the relevant documentation sections ('Attributes and Resources' & 'Configuration') using the mesos-website-container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39102: Added documentation for JSON resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/#review105570
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39211, 39018, 39102]
All tests passed.
- Mesos ReviewBot
On Nov. 7, 2015, 12:18 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39102/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2015, 12:18 a.m.)
>
>
> Review request for mesos, Adam B and Neil Conway.
>
>
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for JSON resources.
>
>
> Diffs
> -----
>
> docs/attributes-resources.md 5dfc7fce286a23a10c8683122175b9bad858b2c1
> docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
> src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
>
> Diff: https://reviews.apache.org/r/39102/diff/
>
>
> Testing
> -------
>
> Viewed the relevant documentation sections ('Attributes and Resources' & 'Configuration') using the mesos-website-container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39102: Added documentation for JSON resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/#review105568
-----------------------------------------------------------
Bad patch!
Reviews applied: [39211, 39018]
Failed command: ./support/apply-review.sh -n -r 39018
Error:
2015-11-07 03:03:58 URL:https://reviews.apache.org/r/39018/diff/raw/ [45596/45596] -> "39018.patch" [1]
error: patch failed: src/common/resources.cpp:254
error: src/common/resources.cpp: patch does not apply
error: patch failed: src/tests/resources_tests.cpp:163
error: src/tests/resources_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 7, 2015, 12:18 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39102/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2015, 12:18 a.m.)
>
>
> Review request for mesos, Adam B and Neil Conway.
>
>
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for JSON resources.
>
>
> Diffs
> -----
>
> docs/attributes-resources.md 5dfc7fce286a23a10c8683122175b9bad858b2c1
> docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
> src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
>
> Diff: https://reviews.apache.org/r/39102/diff/
>
>
> Testing
> -------
>
> Viewed the relevant documentation sections ('Attributes and Resources' & 'Configuration') using the mesos-website-container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39102: Added documentation for JSON resources.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/#review105611
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Nov. 6, 2015, 4:18 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39102/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 4:18 p.m.)
>
>
> Review request for mesos, Adam B and Neil Conway.
>
>
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for JSON resources.
>
>
> Diffs
> -----
>
> docs/attributes-resources.md 5dfc7fce286a23a10c8683122175b9bad858b2c1
> docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
> src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
>
> Diff: https://reviews.apache.org/r/39102/diff/
>
>
> Testing
> -------
>
> Viewed the relevant documentation sections ('Attributes and Resources' & 'Configuration') using the mesos-website-container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39102: Added documentation for JSON resources.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/
-----------------------------------------------------------
(Updated Nov. 7, 2015, 12:18 a.m.)
Review request for mesos, Adam B and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-2467
https://issues.apache.org/jira/browse/MESOS-2467
Repository: mesos
Description
-------
Added documentation for JSON resources.
Diffs (updated)
-----
docs/attributes-resources.md 5dfc7fce286a23a10c8683122175b9bad858b2c1
docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
Diff: https://reviews.apache.org/r/39102/diff/
Testing
-------
Viewed the relevant documentation sections ('Attributes and Resources' & 'Configuration') using the mesos-website-container: https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 39102: Added documentation for JSON resources.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/
-----------------------------------------------------------
(Updated Nov. 6, 2015, 7:41 p.m.)
Review request for mesos, Adam B and Neil Conway.
Changes
-------
Addressed comments.
Bugs: MESOS-2467
https://issues.apache.org/jira/browse/MESOS-2467
Repository: mesos
Description
-------
Added documentation for JSON resources.
Diffs (updated)
-----
docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447
docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
Diff: https://reviews.apache.org/r/39102/diff/
Testing
-------
Viewed the relevant documentation sections ('Attributes and Resources' & 'Configuration') using the mesos-website-container: https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 39102: Added documentation for JSON resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/#review105246
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39211, 39018, 39102]
All tests passed.
- Mesos ReviewBot
On Nov. 4, 2015, 5:26 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39102/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 5:26 p.m.)
>
>
> Review request for mesos, Adam B and Neil Conway.
>
>
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for JSON resources.
>
>
> Diffs
> -----
>
> docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447
> docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
>
> Diff: https://reviews.apache.org/r/39102/diff/
>
>
> Testing
> -------
>
> Viewed the relevant documentation sections ('Attributes and Resources' & 'Configuration') using the mesos-website-container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>