You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by olegz <gi...@git.apache.org> on 2016/02/14 21:46:39 UTC
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/222
NIFI-614 Added initial support for new style JMS
NIFI-614 finalized JMSConnectionFactoryProvider ControllerService
NIFI-614 finalized implementation of both Processors and ControllerService
NIFI-614 added initial documentation
NIFI-614 polishing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-614
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/222.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #222
----
commit 1a488c267ff02b70684f90c33286dbca7cd4df41
Author: Oleg Zhurakousky <ol...@suitcase.io>
Date: 2016-01-26T14:21:46Z
NIFI-614 Added initial support for new style JMS
NIFI-614 finalized JMSConnectionFactoryProvider ControllerService
NIFI-614 finalized implementation of both Processors and ControllerService
NIFI-614 added initial documentation
NIFI-614 polishing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #222: NIFI-614 Added initial support for new style JMS
Posted by jugi92 <gi...@git.apache.org>.
Github user jugi92 commented on the issue:
https://github.com/apache/nifi/pull/222
I found out that it works if the SSL Context Service is configured correctly and the dynamic property is provided as shown below:
Property | Value
----------|-----------
SSL Context Service | SSLContextServiceForJMS
SSLTrustedCertificate | /path/to/TrustedCertificate.cer
So the dynamic attributes are a really valuable thing.
Thanks
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195427093
What was the motivation for creating an additional details page for the Publish/Consume processors that is just a summary and an overview of the configuration? Both of those could be conveyed using the CapabilityDescription tag and the property descriptions. It also makes it harder to maintain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196855425
So the problem with Tibco and SSL is that Tibco does things differently then other providers. In other words they don't use SSLContext and instead rely on setting individual properties inside their implementation of ConnectionFactory. The good thing is we can extract them from SSLContext, but need ti know exactly what we need. That said, propose to release this new JMS support with understanding that it does not yet support Tibco SSL and add it later as part of the enhancement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #222: NIFI-614 Added initial support for new style JMS
Posted by mosermw <gi...@git.apache.org>.
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/222
Since TIBCO libraries don't fall under a license that is compatible with the Apache License 2.0, Apache NiFi cannot distribute a solution that is specific to TIBCO. But you should be able to build an extension to Apache NiFi that works for you. Here is an example for how you might approach building a NiFi extension for this [mosermw/nifi-jms-providers-bundle](https://github.com/mosermw/nifi-jms-providers-bundle).
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by mosermw <gi...@git.apache.org>.
Github user mosermw commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196508227
Tested using Tibco with SSL, didn't work.
ERROR o.a.n.jms.processors.PublishJMS org.springframework.jms.JmsSecurityException: Can not initialize SSL client: no trusted certificates are set; nested exception is javax.jms.JMSSecurityException: Can not initialize SSL client: no trusted certificates are set
at org.springframework.jms.support.JmsUtils.convertJmsAccessException(JmsUtils.java:291)
at org.springframework.jms.support.JmsAccessor.convertJmsAccessException(JmsAccessor.java:169)
at org.springframework.jms.core.JmsTemplate.execute(JmsTemplate.java:497)
at org.springframework.jms.core.JmsTemplate.send(JmsTemplate.java:580)
...
at org.apache.nifi.jms.processors.JMSPublisher.publish(JMSPublisher.java:75)
Caused by: javax.jms.JMSSecurityException: Can not initialize SSL client: no trusted certificates are set
at com.tibco.tibjms.TibjmsLinkSSL._initSSL
at com.tibco.tibjms.TibjmsLinkSSL.connect
at com.tibco.tibjms.TibjmsConnection._create
at com.tibco.tibjms.TibjmsConnection.<init>
at com.tibco.tibjms.TibjmsxCFImpl._createImpl
at com.tibco.tibjms.TibjmsxCFImpl._createConnection
at com.tibco.tibjms.TibjmsConnectionFactory.createConnection
at org.springframework.jms.connection.UserCredentialsConnectionFactoryAdapter.doCreateConnection
...
at org.springframework.jms.support.JmsAccessor.createConnection
at org.springframework.jms.core.JmsTemplate.execute
I'm not sure how to pass the keystores from the SSL Context Service property of JMSConnectionFactoryProvider into the instance of the MQ ConnectionFactory Implementation using the configuration options provided.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #222: NIFI-614 Added initial support for new style JMS
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/222
@jugi92 you're right that the NIFi support for dynamic/custom attributes to help with Vendor differences. However, even in that case it appears (though I've not personally verified) that this isn't enough in the Tibco case for getting TLS setup propertly for them. For the NiFi method to work the custom attributes need to correspond to bean properties/setters. If their approach requires more awareness then it will require a specific component for them. I am aware of plenty of NiFi/Tibco integrations but they're outside of Apache at this point given what Mike highlighted above.
If you are able to investigate the Tibco TLS setup requirements and see what the gap is perhaps it can be done in a vendor neutral way
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196988395
I am a +1 on merging this PR in (once commits have been squashed).
I reviewed the code, did a contrib check build and did basic testing with ActiveMQ. With @digitalplummer having done more extensive testing with other JMS brokers, I am satisfied with the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195413029
New commits fail contrib-check for these reasons:
[INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @ nifi-jms-processors ---
[WARNING] src/main/java/org/apache/nifi/jms/processors/JMSPublisher.java[63] (javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty description.
[WARNING] src/main/java/org/apache/nifi/jms/processors/JMSPublisher.java[71] (javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty description.
[WARNING] src/main/java/org/apache/nifi/jms/processors/JMSPublisher.java[72] (javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty description.
[WARNING] src/main/java/org/apache/nifi/jms/processors/MessageBodyToBytesConverter.java[35] (javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty description.
[WARNING] src/main/java/org/apache/nifi/jms/processors/MessageBodyToBytesConverter.java[36] (javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty description.
[WARNING] src/main/java/org/apache/nifi/jms/processors/MessageBodyToBytesConverter.java[48] (javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty description.
[WARNING] src/main/java/org/apache/nifi/jms/processors/MessageBodyToBytesConverter.java[49] (javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195427526
We'll be adding more docs in there in the future related to specific providers (e.g., IBM, Tibco etc), so treat it as place holder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195528105
Build is still failing contrib check after the latest patches due to:
[INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @ nifi-jms-cf-service ---
[WARNING] src/main/java/org/apache/nifi/jms/cf/JMSConnectionFactoryProvider.java[58] (regexp) RegexpSinglelineJava: Line has trailing whitespace.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196861594
Agreed and the JIRA is https://issues.apache.org/jira/browse/NIFI-1628
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #222: NIFI-614 Added initial support for new style JMS
Posted by ragnarotech <gi...@git.apache.org>.
Github user ragnarotech commented on the issue:
https://github.com/apache/nifi/pull/222
@jugi92 this solution does not work with tibjms.jar v8.x In v8 tibco adds "void setSSLTrustedCertificate(byte[] certificate, java.lang.String trustedEncoding)" to it's TibjmsConnectionFactory class, which is what method the jms util finds first causing a too few arguments exception.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/222#discussion_r53622460
--- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-cf-service/.gitignore ---
@@ -0,0 +1 @@
+/lib/
--- End diff --
It isn't ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196527092
@mosermw shouldn't you just be able to create a typical SSL controller service and set the "SSL Context Service" property to point to it? This should automatically use the properties set in the SSL controller service.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195006367
Following the pattern for Controller Services and their API in nifi-standard-services, JMSConnectionFactoryProviderDefinition should be in it's own package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195428868
Why are the docs needed as place holders? It is not a breaking change to adding additional documentation pages in the future. Details regarding simple capability description and processor property descriptors should follow the same convention other components follow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by mosermw <gi...@git.apache.org>.
Github user mosermw commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196532379
Yep, that's what I did. The TibjmsConnectionFactory must not see the truststore I set in the SSL Context Service. I'm worried that different JMS providers require different SSL setup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by digitalplummer <gi...@git.apache.org>.
Github user digitalplummer commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196402216
Tested on IBM MQ 7.5 and greater
WebSphere
Tibco
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/222#discussion_r53268977
--- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-cf-service/.gitignore ---
@@ -0,0 +1 @@
+/lib/
--- End diff --
why is this necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #222: NIFI-614 Added initial support for new style JMS
Posted by jugi92 <gi...@git.apache.org>.
Github user jugi92 commented on the issue:
https://github.com/apache/nifi/pull/222
Was the Tibco issue ever followed up on?
I tried to set sSLTrustedCertificate as dynamic property but it gives the following error:
```
2017-12-19 17:48:09,788 ERROR [StandardProcessScheduler Thread-7] o.a.n.c.s.StandardControllerServiceNode JMSConnectionFactoryProvider[id=a7cf3b99-c426-18a4-0000-00003dc28240] Failed to invoke @OnEnabled method due to java.lang.IllegalStateException: java.lang.IllegalStateException: Failed to set property sSLTrustedCertificate: {}
java.lang.IllegalStateException: java.lang.IllegalStateException: Failed to set property sSLTrustedCertificate
```
Tibco Java Doc is available here:
https://docs.tibco.com/pub/enterprise_message_service/6.3.0-february-2012/doc/html/tib_ems_api_reference/api/javadoc/com/tibco/tibjms/TibjmsConnectionFactory.html#setSSLTrustedCertificate(java.lang.String)
---
[GitHub] nifi issue #222: NIFI-614 Added initial support for new style JMS
Posted by jugi92 <gi...@git.apache.org>.
Github user jugi92 commented on the issue:
https://github.com/apache/nifi/pull/222
I understand that Apache Nifi can not deliver custom solutions for individual proprietary JMS providers. But as I understood, the dynamic property was build exactly for the purpose to set custom attributes of the Connection Factory as mentioned in the Documentation:
[JMSConnectionFactoryProvider](https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi/nifi-jms-cf-service-nar/1.4.0/org.apache.nifi.jms.cf.JMSConnectionFactoryProvider/index.html)
So the question is if this is working for other parameters and the implementation on Tibco Site does not allow the dynamic setting of attributes or is it a problem in Nifi that it does not call the set Method of the attribute correctly?
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196858986
i am on the same page of this being a good start oleg provided the JIRA is created to enable ssl context to provide info for providers that want it. We don't have support for tibco ssl in apache now anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196535593
I'll look at it. I think I know what's going on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/222
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-194997331
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---