You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2009/04/01 00:43:50 UTC
[jira] Created: (HADOOP-5604) TestBinaryPartitioner javac warnings.
TestBinaryPartitioner javac warnings.
-------------------------------------
Key: HADOOP-5604
URL: https://issues.apache.org/jira/browse/HADOOP-5604
Project: Hadoop Core
Issue Type: Bug
Components: mapred, test
Affects Versions: 0.21.0
Reporter: Konstantin Shvachko
Fix For: 0.21.0
This is introduced by HADOOP-5528.
All of them about using unparametrized types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5604) TestBinaryPartitioner javac
warnings.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694356#action_12694356 ]
Konstantin Shvachko commented on HADOOP-5604:
---------------------------------------------
No, I don't think we should suppress the warnings.
The test should be written correctly using parametrized types.
> TestBinaryPartitioner javac warnings.
> -------------------------------------
>
> Key: HADOOP-5604
> URL: https://issues.apache.org/jira/browse/HADOOP-5604
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, test
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: 5604-0.patch
>
>
> This is introduced by HADOOP-5528.
> All of them about using unparametrized types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5604) TestBinaryPartitioner javac warnings.
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5604:
----------------------------------
Attachment: 5604-0.patch
> TestBinaryPartitioner javac warnings.
> -------------------------------------
>
> Key: HADOOP-5604
> URL: https://issues.apache.org/jira/browse/HADOOP-5604
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, test
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: 5604-0.patch
>
>
> This is introduced by HADOOP-5528.
> All of them about using unparametrized types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5604) TestBinaryPartitioner javac warnings.
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5604:
----------------------------------
Status: Patch Available (was: Open)
> TestBinaryPartitioner javac warnings.
> -------------------------------------
>
> Key: HADOOP-5604
> URL: https://issues.apache.org/jira/browse/HADOOP-5604
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, test
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: 5604-0.patch
>
>
> This is introduced by HADOOP-5528.
> All of them about using unparametrized types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5604) TestBinaryPartitioner javac
warnings.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694491#action_12694491 ]
Hadoop QA commented on HADOOP-5604:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12404279/5604-0.patch
against trunk revision 760783.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/88/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/88/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/88/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/88/console
This message is automatically generated.
> TestBinaryPartitioner javac warnings.
> -------------------------------------
>
> Key: HADOOP-5604
> URL: https://issues.apache.org/jira/browse/HADOOP-5604
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, test
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: 5604-0.patch
>
>
> This is introduced by HADOOP-5528.
> All of them about using unparametrized types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5604) TestBinaryPartitioner javac
warnings.
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694357#action_12694357 ]
Chris Douglas commented on HADOOP-5604:
---------------------------------------
The value type is ignored by the partitioner and wholly irrelevant. Supplying a type for the null values passed in for the unit test is pointless.
> TestBinaryPartitioner javac warnings.
> -------------------------------------
>
> Key: HADOOP-5604
> URL: https://issues.apache.org/jira/browse/HADOOP-5604
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, test
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: 5604-0.patch
>
>
> This is introduced by HADOOP-5528.
> All of them about using unparametrized types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5604) TestBinaryPartitioner javac
warnings.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694694#action_12694694 ]
Konstantin Shvachko commented on HADOOP-5604:
---------------------------------------------
HADOOP-5528 should have been reversed.
In addition to 32 javac warnings, this patch introduces a new AND already deprecated class. It also introduces two identical tests located in two different packages, which are produced by code replication.
It needs to be re-reviewed.
> TestBinaryPartitioner javac warnings.
> -------------------------------------
>
> Key: HADOOP-5604
> URL: https://issues.apache.org/jira/browse/HADOOP-5604
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, test
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: 5604-0.patch
>
>
> This is introduced by HADOOP-5528.
> All of them about using unparametrized types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5604) TestBinaryPartitioner javac
warnings.
Posted by "Klaas Bosteels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694761#action_12694761 ]
Klaas Bosteels commented on HADOOP-5604:
----------------------------------------
Konstantin:
* The deprecated class is there because we want to support both the new and the old mapreduce API. This does make sense, in my opinion, since the old API is still used heavily (personally I'm using the {{BinaryPartitioner}} from Streaming, for instance, which still uses the old API and might continue doing so for while). The deprecated version just extends the one using the new API though, so there's not code duplication.
* The {{null}} parameter is just because the value parameter is irrelevant for this particular partitioner, but obviously we do want it to take this parameter because it has to implement the partitioner interface.
* The tests are indeed replicated, but they are not identical, since one of them uses the deprecated class while the other uses the class from the new API. In theory it would be sufficient to test only the non-deprecated class (because the deprecated one extends the non-deprecated one), but it felt safer to have a unit test for both.
I was aware that the unit tests added by the patch generate javac warnings, but I thought javac warnings for unit tests were not considered harmful. We could suppress the warnings like Chris did in his patch, but apart from that I don't think anything should change.
> TestBinaryPartitioner javac warnings.
> -------------------------------------
>
> Key: HADOOP-5604
> URL: https://issues.apache.org/jira/browse/HADOOP-5604
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, test
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: 5604-0.patch
>
>
> This is introduced by HADOOP-5528.
> All of them about using unparametrized types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-5604) TestBinaryPartitioner javac
warnings.
Posted by "Klaas Bosteels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Klaas Bosteels resolved HADOOP-5604.
------------------------------------
Resolution: Fixed
Fixed by the latest patch for HADOOP-5528.
> TestBinaryPartitioner javac warnings.
> -------------------------------------
>
> Key: HADOOP-5604
> URL: https://issues.apache.org/jira/browse/HADOOP-5604
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, test
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: 5604-0.patch
>
>
> This is introduced by HADOOP-5528.
> All of them about using unparametrized types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5604) TestBinaryPartitioner javac warnings.
Posted by "Klaas Bosteels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Klaas Bosteels updated HADOOP-5604:
-----------------------------------
Status: Open (was: Patch Available)
> TestBinaryPartitioner javac warnings.
> -------------------------------------
>
> Key: HADOOP-5604
> URL: https://issues.apache.org/jira/browse/HADOOP-5604
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, test
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: 5604-0.patch
>
>
> This is introduced by HADOOP-5528.
> All of them about using unparametrized types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.