You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/09/14 22:55:37 UTC
Review Request 38367: Added NetworkInfo message to ContainerInfo and
TaskStatus.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/
-----------------------------------------------------------
Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
Bugs: MESOS-3013
https://issues.apache.org/jira/browse/MESOS-3013
Repository: mesos
Description
-------
This allows the frameworks to specify an intent to enable ip-per-container. The
IP information is supplied back to the framework as well as state.json endpoints
by including NetworkInfo inside TaskStatus.
Diffs
-----
include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4
src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1
src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102
Diff: https://reviews.apache.org/r/38367/diff/
Testing
-------
Added new tests and ran make check.
Thanks,
Kapil Arya
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Till Toenshoff <to...@me.com>.
> On Dec. 7, 2015, 10:07 p.m., Till Toenshoff wrote:
> > include/mesos/mesos.proto, line 1466
> > <https://reviews.apache.org/r/38367/diff/4/?file=1075756#file1075756line1466>
> >
> > Why are we missing index 6 here?
Also missing in the V1 API.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review109199
-----------------------------------------------------------
On Sept. 16, 2015, 10 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 10 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842
> src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b
> src/tests/slave_tests.cpp 447c43c96ce0c043e37319bb213723ed33820f8a
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review109199
-----------------------------------------------------------
include/mesos/mesos.proto (line 1466)
<https://reviews.apache.org/r/38367/#comment168673>
Why are we missing index 6 here?
- Till Toenshoff
On Sept. 16, 2015, 10 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 10 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842
> src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b
> src/tests/slave_tests.cpp 447c43c96ce0c043e37319bb213723ed33820f8a
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review109208
-----------------------------------------------------------
include/mesos/mesos.proto (line 1165)
<https://reviews.apache.org/r/38367/#comment168687>
We missed to update the V1 API with this change, it seems.
include/mesos/mesos.proto (lines 1470 - 1477)
<https://reviews.apache.org/r/38367/#comment168690>
We missed to update the V1 API with this change, it seems.
- Till Toenshoff
On Sept. 16, 2015, 10 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 10 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842
> src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b
> src/tests/slave_tests.cpp 447c43c96ce0c043e37319bb213723ed33820f8a
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/
-----------------------------------------------------------
(Updated Sept. 16, 2015, 6 p.m.)
Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
Changes
-------
rebased; addressed issues.
Bugs: MESOS-3013
https://issues.apache.org/jira/browse/MESOS-3013
Repository: mesos
Description
-------
This allows the frameworks to specify an intent to enable ip-per-container. The
IP information is supplied back to the framework as well as state.json endpoints
by including NetworkInfo inside TaskStatus.
Diffs (updated)
-----
include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842
src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b
src/tests/slave_tests.cpp 447c43c96ce0c043e37319bb213723ed33820f8a
Diff: https://reviews.apache.org/r/38367/diff/
Testing
-------
Added new tests and ran make check.
Thanks,
Kapil Arya
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review99303
-----------------------------------------------------------
To Vinod's point; can we use JSON::protobuf() and override the fields we want custom formatting for?
include/mesos/mesos.proto (line 1392)
<https://reviews.apache.org/r/38367/#comment156205>
s/upto/up to/
- Niklas Nielsen
On Sept. 15, 2015, 7:05 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 7:05 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842
> src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b
> src/tests/slave_tests.cpp 447c43c96ce0c043e37319bb213723ed33820f8a
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review99301
-----------------------------------------------------------
Ship it!
include/mesos/mesos.proto (lines 1165 - 1167)
<https://reviews.apache.org/r/38367/#comment156202>
I don't think you need to mention about how this field is populated (hook etc). Also the comment about the network_info.ip belongs where ContainerStatus/NetworkInfo is defined.
include/mesos/mesos.proto (line 1371)
<https://reviews.apache.org/r/38367/#comment156203>
s/not/no/
- Vinod Kone
On Sept. 16, 2015, 2:05 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 2:05 a.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842
> src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b
> src/tests/slave_tests.cpp 447c43c96ce0c043e37319bb213723ed33820f8a
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/
-----------------------------------------------------------
(Updated Sept. 15, 2015, 10:05 p.m.)
Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
Changes
-------
rebased
Bugs: MESOS-3013
https://issues.apache.org/jira/browse/MESOS-3013
Repository: mesos
Description
-------
This allows the frameworks to specify an intent to enable ip-per-container. The
IP information is supplied back to the framework as well as state.json endpoints
by including NetworkInfo inside TaskStatus.
Diffs (updated)
-----
include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842
src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b
src/tests/slave_tests.cpp 447c43c96ce0c043e37319bb213723ed33820f8a
Diff: https://reviews.apache.org/r/38367/diff/
Testing
-------
Added new tests and ran make check.
Thanks,
Kapil Arya
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/
-----------------------------------------------------------
(Updated Sept. 15, 2015, 5:06 p.m.)
Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
Changes
-------
Addressed Vinod's and Nik's comments.
Bugs: MESOS-3013
https://issues.apache.org/jira/browse/MESOS-3013
Repository: mesos
Description
-------
This allows the frameworks to specify an intent to enable ip-per-container. The
IP information is supplied back to the framework as well as state.json endpoints
by including NetworkInfo inside TaskStatus.
Diffs (updated)
-----
include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4
src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1
src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102
Diff: https://reviews.apache.org/r/38367/diff/
Testing
-------
Added new tests and ran make check.
Thanks,
Kapil Arya
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Vinod Kone <vi...@gmail.com>.
> On Sept. 14, 2015, 10:19 p.m., Vinod Kone wrote:
> > src/common/http.cpp, lines 153-194
> > <https://reviews.apache.org/r/38367/diff/1/?file=1072964#file1072964line153>
> >
> > Why custom models? Can we not use the protobuf to json converters?
>
> Kapil Arya wrote:
> This is mostly due to Labels. The way they are setup right now, we get sth like:
> ```
> { "labels": { "labels": [ { "key": "k", "value": "v" } ... ] } }
> ```
>
> The explicit modelling removes the extra label from within the JSON to make it more readable.
we have a goal to back our admin endpoints (like state.json) with protobufs so that it is easy to convey the schema to the operators. so i would prefer we use standard protobuf to json converters.
but, looks like "Labels" is already being modeled in a custom way in the state endpoint. so i'm fine if you want to keep it consistent. feel free to drop the issue.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98932
-----------------------------------------------------------
On Sept. 16, 2015, 2:05 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 2:05 a.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842
> src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b
> src/tests/slave_tests.cpp 447c43c96ce0c043e37319bb213723ed33820f8a
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Sept. 14, 2015, 6:19 p.m., Vinod Kone wrote:
> > src/common/http.cpp, lines 153-194
> > <https://reviews.apache.org/r/38367/diff/1/?file=1072964#file1072964line153>
> >
> > Why custom models? Can we not use the protobuf to json converters?
This is mostly due to Labels. The way they are setup right now, we get sth like:
```
{ "labels": { "labels": [ { "key": "k", "value": "v" } ... ] } }
```
The explicit modelling removes the extra label from within the JSON to make it more readable.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98932
-----------------------------------------------------------
On Sept. 15, 2015, 5:06 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 5:06 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4
> src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1
> src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98932
-----------------------------------------------------------
include/mesos/mesos.proto (lines 1163 - 1164)
<https://reviews.apache.org/r/38367/#comment155662>
Do we have to say that this information is resolved at setup time? What about status changes during run time? I'm wondering whether we can leverage this for MESOS-3334.
include/mesos/mesos.proto (lines 1369 - 1370)
<https://reviews.apache.org/r/38367/#comment155666>
s/0/1/
s/1/2/
enum starting with "0" is bad because it is hard to distinguish the case when the enum is not set.
include/mesos/mesos.proto (line 1390)
<https://reviews.apache.org/r/38367/#comment155668>
s/. E.g./, e.g./
src/common/http.cpp (lines 153 - 194)
<https://reviews.apache.org/r/38367/#comment155672>
Why custom models? Can we not use the protobuf to json converters?
src/tests/master_tests.cpp (line 3247)
<https://reviews.apache.org/r/38367/#comment155682>
this test doesn't seem to test label values?
src/tests/master_tests.cpp (line 3320)
<https://reviews.apache.org/r/38367/#comment155679>
kill this?
src/tests/slave_tests.cpp (line 2223)
<https://reviews.apache.org/r/38367/#comment155681>
s/an is/is/ ?
- Vinod Kone
On Sept. 14, 2015, 8:55 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 8:55 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4
> src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1
> src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Sept. 14, 2015, 6:43 p.m., Niklas Nielsen wrote:
> > src/slave/slave.cpp, line 2760
> > <https://reviews.apache.org/r/38367/diff/1/?file=1072965#file1072965line2760>
> >
> > s/the container IP address if/the container IP address with the IP from the agent PID, if/ or something that specifies where you are getting the IP from.
> >
> > Would it be more precise to get the IP from the executor PID?
Updated the comment and added a TODO.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98936
-----------------------------------------------------------
On Sept. 15, 2015, 5:06 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 5:06 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4
> src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1
> src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98936
-----------------------------------------------------------
src/slave/slave.cpp (line 2760)
<https://reviews.apache.org/r/38367/#comment155697>
s/the container IP address if/the container IP address with the IP from the agent PID, if/ or something that specifies where you are getting the IP from.
Would it be more precise to get the IP from the executor PID?
src/tests/master_tests.cpp (line 3293)
<https://reviews.apache.org/r/38367/#comment155696>
Can we const this?
src/tests/slave_tests.cpp (line 2269)
<https://reviews.apache.org/r/38367/#comment155694>
Can we const this string?
src/tests/slave_tests.cpp (line 2271)
<https://reviews.apache.org/r/38367/#comment155695>
Quite a long piece of straight line code; mind throwing in some comments breaking it up a bit and explaining what you are doing?
- Niklas Nielsen
On Sept. 14, 2015, 1:55 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 1:55 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4
> src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1
> src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1163
> > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1163>
> >
> > We still go by 70 col comments, right? If so, let's wrap the comment blocks.
It's been updated :-) https://github.com/apache/mesos/commit/f9c2604ea97b91f8a9ec3b2863317761679b1c86
> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1362
> > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1362>
> >
> > Request _and_ resolution, right?
> >
> > Can we capture this here?
Fixed.
> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1365
> > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1365>
> >
> > We probably need to have a caveat about the pluggable nature of networking (and that if not enabled, this will be not be interpreted by mesos)
Extended the comment.
> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1376
> > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1376>
> >
> > We should probably mention that it is up to the mesos networking 'provider' to interpret this as either a hint or a requirement for the assigned ip.
Done.
> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1386
> > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1386>
> >
> > We could mention that these groups can be used for isolation
Fixed.
> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1390
> > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1390>
> >
> > pop? :)
Removed.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98926
-----------------------------------------------------------
On Sept. 15, 2015, 5:06 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 5:06 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4
> src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1
> src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38367: Added NetworkInfo message to ContainerInfo
and TaskStatus.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98926
-----------------------------------------------------------
include/mesos/mesos.proto (line 1163)
<https://reviews.apache.org/r/38367/#comment155653>
We still go by 70 col comments, right? If so, let's wrap the comment blocks.
include/mesos/mesos.proto (line 1164)
<https://reviews.apache.org/r/38367/#comment155669>
Wonder if we can enumerate more container information examples that may go into the container status (so it doesn't become a network-only structure)
include/mesos/mesos.proto (line 1362)
<https://reviews.apache.org/r/38367/#comment155654>
Request _and_ resolution, right?
Can we capture this here?
include/mesos/mesos.proto (line 1365)
<https://reviews.apache.org/r/38367/#comment155688>
We probably need to have a caveat about the pluggable nature of networking (and that if not enabled, this will be not be interpreted by mesos)
include/mesos/mesos.proto (line 1376)
<https://reviews.apache.org/r/38367/#comment155683>
We should probably mention that it is up to the mesos networking 'provider' to interpret this as either a hint or a requirement for the assigned ip.
include/mesos/mesos.proto (line 1386)
<https://reviews.apache.org/r/38367/#comment155687>
We could mention that these groups can be used for isolation
include/mesos/mesos.proto (line 1390)
<https://reviews.apache.org/r/38367/#comment155680>
pop? :)
- Niklas Nielsen
On Sept. 14, 2015, 1:55 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 1:55 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the frameworks to specify an intent to enable ip-per-container. The
> IP information is supplied back to the framework as well as state.json endpoints
> by including NetworkInfo inside TaskStatus.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60
> src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156
> src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4
> src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1
> src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102
>
> Diff: https://reviews.apache.org/r/38367/diff/
>
>
> Testing
> -------
>
> Added new tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>